Repository navigation
fix: GitHub-qualified App approvals and copyright footer - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix merge authorization when GitHub accepts the App's native APPROVE as a qualifying protected-branch review. Required review counts, CODEOWNER and last-push rules are verified through GitHub's actual review decision and native exact-head merge; they no longer manufacture an additional human minimum. Unknown or unmet required review evidence blocks merging. Explicit policy minimums still require distinct, current-head, write-capable non-author humans.
Preserve manual-only reviews and explicit-only --merge behavior, required CI, App-bound guards, authorization and OIDC. Add the requested copyright footer and prepare v0.1.0-beta.2.
Validation: npm run check, including 199 tests, typecheck, lint and build. Regression coverage includes GitHub-qualified App approvals, last-push/CODEOWNER decisions, unknown/unmet review evidence, additional human requirements and explicit-only merging. No new live GitHub/inference tests: the operator explicitly waived them. This PR makes no repository protection or credential changes. Normal CI must pass before merging/deploying. Pins will be coordinated to this PR's actual resulting merge SHA; disabled TopkAPI stays untouched.