Repository navigation
Preserve type-import dependencies with the native compiler preprocessor - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve actual TypeScript
import("./module").Typedependencies in the not-yet-rolled-out context parser fix. The initial hand traversal covered runtime imports but omitted import-type nodes. Use the existing pinned compiler’s nativepreProcessFile(...).importedFilesinstead: less code, generated strings/comments still ignored, literal runtime and type imports all retained.Add the type-query case to the actual collector’s missing-dependency regression table. No dependency, resolver execution, budget, sandbox, credential or completeness-policy change. The parser correction has not yet been enabled in production runner pins.
Validation: full Node 24 check (197 tests). Full GitHub CI required before normal merge. Coordinate the final actual merged source SHA and supersede the currently held parser pin proposals only after this fix passes CI. Existing live production pin remains unchanged while the disposable admission budget is time-gated.