Skip to content

Fix false required dependencies in generated code strings - #29

Merged
AppSolves merged 1 commit into
mainfrom
fix/parse-real-context-imports
Nov 15, 2026
Merged

AppSolves merged 1 commit into
mainfrom
fix/parse-real-context-imports

Conversation

@AppSolves

Copy link
Copy Markdown
Owner

The disposable human-mode configuration review failed before inference with review_context_incomplete. Its changed fixture generator contains a quoted generated test with a relative import. The regex dependency collector treated that string as an actual import of the generator and required a file that correctly does not exist in that snapshot.

Use the already installed, pinned TypeScript syntax parser to select real literal imports, exports, import-equals, dynamic imports and require calls. Ignore import-looking generated strings, templates and comments. Keep immutable commit/tree/blob validation, source byte/API budgets, path checks and fail-closed handling of real missing dependencies. No new dependency, project code execution, sandbox permission or credential change.

Validation: full Node 24 check (197 tests), including actual collector completeness for generated strings/comments and rejection for genuine missing import/export/require dependencies. Full GitHub CI includes clean checkout, workerd/D1, browser, actual Codex Docker isolation, actionlint, image vulnerability scan, audit and Wrangler dry-run.

Runner-only change: coordinate actual merged source SHA before rollout. Further live acceptance currently waits for the configured disposable rolling request budget; no counters or required App checks are reset or bypassed.

@AppSolves
AppSolves merged commit 757c28e into main Nov 15, 2026
4 checks passed
@AppSolves
AppSolves deleted the fix/parse-real-context-imports branch November 15, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant