Repository navigation
Fix false required dependencies in generated code strings - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The disposable human-mode configuration review failed before inference with
review_context_incomplete. Its changed fixture generator contains a quoted generated test with a relative import. The regex dependency collector treated that string as an actual import of the generator and required a file that correctly does not exist in that snapshot.Use the already installed, pinned TypeScript syntax parser to select real literal imports, exports, import-equals, dynamic imports and require calls. Ignore import-looking generated strings, templates and comments. Keep immutable commit/tree/blob validation, source byte/API budgets, path checks and fail-closed handling of real missing dependencies. No new dependency, project code execution, sandbox permission or credential change.
Validation: full Node 24 check (197 tests), including actual collector completeness for generated strings/comments and rejection for genuine missing import/export/require dependencies. Full GitHub CI includes clean checkout, workerd/D1, browser, actual Codex Docker isolation, actionlint, image vulnerability scan, audit and Wrangler dry-run.
Runner-only change: coordinate actual merged source SHA before rollout. Further live acceptance currently waits for the configured disposable rolling request budget; no counters or required App checks are reset or bypassed.