Skip to content

Fail unsuccessful reviews and preserve safe execution diagnostics - #11

Merged
AppSolves merged 2 commits into
mainfrom
fix/isolated-review-diagnostics
Nov 14, 2026
Merged

AppSolves merged 2 commits into
mainfrom
fix/isolated-review-diagnostics

Conversation

@AppSolves

Copy link
Copy Markdown
Owner

Failed inference previously returned success after recording its safe fallback, making an unsuccessful AI review a green Actions check. Always propagate the primary failure after reporting it; keep the separately protected publisher eligible to publish only a non-approving result. Progress now explicitly distinguishes fallback publication from completed AI analysis while retaining the actual GitHub workflow conclusion.

Add bounded, allowlisted Docker/Codex/RPC/proxy diagnostics. Discard arbitrary stderr, provider text, credentials, prompts and source. Only the proxy's actual HTTP response supplies upstream status; a local AppError default is not provider HTTP evidence. Preserve Responses endpoint/policy, OIDC, credential isolation and merge restrictions. The historical generic log cannot establish the original inference failure's specific cause.

Validation: Node 24 npm run check (140 tests, typecheck, lint, build), clean-source check, real workerd/D1, Actionlint, Docker build and real pinned Codex with successful/failing synthetic Responses, npm audit, strict image scan and Wrangler dry-run. No real inference, deployment, credential changes or merge performed.

Rollout requires matching immutable source/Worker trust/caller pins after this PR is approved and merged. Pin PRs remain Draft until both use the actual merged source SHA. No database migration, new permissions or OAuth reconnect required. See docs/review-rollout.md.

@AppSolves
AppSolves merged commit 0e93747 into main Nov 14, 2026
4 checks passed
@AppSolves
AppSolves deleted the fix/isolated-review-diagnostics branch November 14, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant