Skip to content

Reject short-name aliases with trailing dots or spaces #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ApolloF merged 1 commit into from
Oct 20, 2026
Merged

Reject short-name aliases with trailing dots or spaces #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/paths/real.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,4 +194,6 @@ var shortNameForm = regexp.MustCompile(`~[0-9]+(\.[^.]*)?$`)
// short name, which may stand for a folder of another name. Other names
// with a "~" are fine: a real short name elsewhere is caught on disk by
// CheckSyncable.
func LooksShort(name string) bool { return shortNameForm.MatchString(name) }
func LooksShort(name string) bool {
return shortNameForm.MatchString(strings.TrimRight(name, ". "))
}
2 changes: 1 addition & 1 deletion internal/paths/real_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func TestResolveShortNameForm(t *testing.T) {
t.Errorf("Resolve(home, %q) refused", rel)
}
}
for _, rel := range []string{"PROGRA~1", "MICROS~1.TXT", "Games/SAVEGA~12", "a~1."} {
for _, rel := range []string{"PROGRA~1", "MICROS~1.TXT", "Games/SAVEGA~12", "a~1.", "PROGRA~1 ", "PROGRA~1..", "MICROS~1.TXT."} {
if p, ok := Resolve(Home, rel); ok {
t.Errorf("Resolve(home, %q) = %q, want refused", rel, p)
}
Expand Down