Skip to content

Protect re-added Drive backups and reject short-name aliases - #32

Closed
ApolloF wants to merge 2 commits into
fix/review-2026-10from
fix/21-review-followup
Closed

ApolloF wants to merge 2 commits into
fix/review-2026-10from
fix/21-review-followup

Conversation

@ApolloF

@ApolloF ApolloF commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Addresses the three findings from the review of the extra #21 commits:

  • Protect re-added Drive backups from mass deletion: remove the game from Forgotten when local backup files return, with a regression test (09716b3; internal/gdrive/sync.go and sync_test.go).
  • Avoid a lasting split error on PCs that do not sync the game: check for nothing to do before returning ErrSplitLink, with TestSplitThroughLinkNotSyncedHere. Already fixed in 753ee64 and included in the base branch; no duplicate change is needed.
  • Reject Windows short-name aliases with trailing dots or spaces, with test coverage (141a3f8; internal/paths/real.go and real_test.go).

Verification on the current head:

  • go vet ./...: passed.
  • go test ./...: passed (some package results cached).
  • npm run check: passed, 0 errors and 0 warnings.
  • npx vitest run: passed, 4 files and 31 tests.
  • wails build: passed (binding generation printed time.Time diagnostics).

@ApolloF

ApolloF commented Oct 20, 2026

Copy link
Copy Markdown
Owner Author

Replaced by #57. The Drive fix was already merged in #31.

@ApolloF ApolloF closed this Oct 20, 2026
@ApolloF
ApolloF deleted the fix/21-review-followup branch October 21, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant