Skip to content

Today: check time in the corner (for review) - #17

Merged
ApolloF merged 3 commits into
mainfrom
ApolloF/Time-corner
Oct 12, 2026
Merged

ApolloF merged 3 commits into
mainfrom
ApolloF/Time-corner

Conversation

@ApolloF

@ApolloF ApolloF commented Oct 11, 2026

Copy link
Copy Markdown
Owner

What

A clock chip in Today's header (left of the calendar button). It shows "Now" by default. Tap it to pick a time; while a time is set, every one-tap check on Today records that time, like MacroFactor's logging time.

  • Applies to: the round check, "Log all", "Log missed as taken" and checks on a picked past day (picked day + chosen time).
  • Not applied to: the Log dose / BP / note / symptom sheets (they keep their own Now/Earlier choice), notifications and the widget.
  • Snackbar says "… taken at 8:00" when the chosen time was used.
  • Reset: the dialog's "Now" button, leaving Today or the app (ON_STOP), or the logical day changing.
  • A time before Settings › Day starts at counts as the night after (SlotTimes.atTimeOn, 1:00 with a 4:00 day start).

Open questions

  • Worth the header space, or bloat? The existing "Check records: scheduled / current time" setting and the Log dose sheet already cover part of this.
  • Should the sheets (extra dose, BP, note) start at the chosen time too?
  • Reset on leaving Today, or keep it until set back?

Tests

  • LogicalDayTest.aChosenTimeBeforeTheDayStartIsTheNightAfter
  • CheckTimeTest (Robolectric): pick a time, check records it, "Now" resets.
  • Ran locally: :core:domain:test assembleDebug pass; :app:testDebugUnitTest for CheckTimeTest, TodayScreenTest, TodaySiteTest, LargeFontLayoutTest, TouchTargetTest pass. Not run: the full Robolectric suite, emulator SmokeTest (left to CI).

@ApolloF
ApolloF marked this pull request as ready for review October 11, 2026 23:16
@ApolloF
ApolloF enabled auto-merge (squash) October 11, 2026 23:16
@ApolloF
ApolloF merged commit 7be96db into main Oct 12, 2026
3 checks passed
@ApolloF
ApolloF deleted the ApolloF/Time-corner branch October 12, 2026 15:13
@ApolloF ApolloF mentioned this pull request Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant