Repository navigation
fix: harden auth, imports, uploads, and task leases - #87
Conversation
AnnaSuSu
left a comment
There was a problem hiding this comment.
Three issues in the auth and task-lease hardening need to be addressed before merging. Each was independently reproduced against commit 52356cf; the inline comments describe the trigger and the observed result.
Validation: all 513 backend tests passed locally in an environment that permits the WebSocket tests to listen on loopback, and all three GitHub CI jobs passed. The additional reproductions confirm scenarios that the existing tests do not cover.
AnnaSuSu
left a comment
There was a problem hiding this comment.
All three previous findings are fixed in 2f064f2. I independently reran the original IP rate-limit bypass, old-password login race, and stale review/profile overwrite scenarios; all now preserve the intended security and task ownership boundaries.
Validation: 531 backend tests passed, all three independent regression scenarios passed, both TypeScript checks and runtime boundary checks passed, and all three GitHub CI jobs passed on this exact head.
Summary
Server deployments previously accepted placeholder credentials, password changes did not revoke existing JWTs, and expired task workers could overwrite replacement results. This change hardens authentication and request handling, prevalidates personal archives, and prevents cancelled review/profile work from committing stale results.
Validation