Repository navigation
[codex] Reject malformed backup restores - #9
Draft
AndreKalberer wants to merge 1 commit into
Draft
AndreKalberer wants to merge 1 commit into
AndreKalberer wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed JSON backups such as
{"favorites":42}or an envelope withstate: []previously normalized to empty defaults and could replace the saved library after restore confirmation. Validate backup structure and entries before normalization so invalid restores preserve favorites, history, progress, and preferences. Valid current exports and partial legacy backups remain supported, including intentionally empty fields and legacy numeric strings.Add unit regressions and a repeatable desktop smoke test covering rejected malformed restores and successful legacy/current restores through the actual preload bridge, IPC filesystem reader, restore button, and saved state. The test substitutes the native file picker and accepts confirmation automatically using an isolated profile.
Validation: regression demonstrated failing against the original parser;
npm run test:consumerpassed; combined Windows packaged smoke tests passed; independent final and integration reviews reported no findings. The new backup smoke is included in default desktop and packaged checks.