Repository navigation
[codex] Cancel obsolete PDF loads and renders - #25
Draft
AndreKalberer wants to merge 1 commit into
Draft
AndreKalberer wants to merge 1 commit into
AndreKalberer wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a PDF is cleared or replaced while decoding or rendering, its pending work can complete later and overwrite the new reader state or paint stale pixels. Rapid page or zoom changes can also finish out of order.
Track ownership of the PDF loading and render tasks, destroy obsolete loads, cancel obsolete renders, and ignore stale results. Render into a detached canvas and copy pixels only when the document and generation remain current. Page navigation reports current failures without letting cancelled work disturb the replacement reader.
This is the PDF cancellation slice only, stacked on #19 (
codex/hbr005-epub-resources). The three changed files are the renderer, a real-decoder cancellation smoke test, and its registration in the desktop smoke runner. No release version or installer metadata changes.Validation:
isPackaged, context isolation and sandbox enabled, and Node integration disabled; testing used isolated temporary profiles.Packaged verification was a scoped QA package copy, not a new released build or installer. No installation was performed. Initial launches from a temporary executable location stalled renderer debugging; the same package in the repository QA location passed without production changes.