Repository navigation
[codex] Fix TV section navigation focus - #17
Draft
AndreKalberer wants to merge 1 commit into
Draft
AndreKalberer wants to merge 1 commit into
AndreKalberer wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching TV sections could leave focus on the document body after the focused card was removed. The broad
[data-section]selector also matched the body, which carries the current section, so focus restoration and navigation state could target it instead of the visible navigation button.Scope section listeners, active state, and focus restoration to
.tv-nav button[data-section]. Add an offline DOM regression capture to the existing TV smoke runner covering Home Continue to LG Back (461), section changes after card removal, My List, the brand link, and return from detail/search overlays. It checks visible navigation focus, exactly one active navigation button, and absence of navigation state on the body.Validation passed:
npm testandnpm run test:tv-smoke, including the new focus capture.Physical LG remote/device verification remains unperformed. No desktop, version, dependency, generated package, or installer changes are included.