Skip to content

[PWGLF,PWGMM] Add DCA Mc QA + cleanup#17116

Merged
gbencedi merged 2 commits into
AliceO2Group:masterfrom
gbencedi:master
Jul 18, 2026
Merged

[PWGLF,PWGMM] Add DCA Mc QA + cleanup#17116
gbencedi merged 2 commits into
AliceO2Group:masterfrom
gbencedi:master

Conversation

@gbencedi

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot changed the title Add DCA Mc QA + cleanup [PWGLF,PWGMM] Add DCA Mc QA + cleanup Jul 17, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 10f44ac at 2026-07-17 20:24:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 55 errors and 7 warnings.'
Found 55 errors and 7 warnings.
++ [[ 55 -gt 0 ]]
++ cat /sw/BUILD/a4724b637f5a2a0388fe2b55aed7d2798010fcc4/O2Physics-code-check/errors.txt
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:25:1: error: included header fwdtrackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:49:1: error: included header TrackFwd.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:93:23: error: unused variable 'CintOne' [clang-diagnostic-unused-const-variable,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:94:23: error: unused variable 'CintTwo' [clang-diagnostic-unused-const-variable,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:108:15: error: unused variable 'CtrackToCollEvtType' [clang-diagnostic-unused-const-variable,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:319:36: error: variable 'mapVtxXrec' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:320:36: error: variable 'mapVtxYrec' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:321:36: error: variable 'mapVtxZrec' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:322:36: error: variable 'mapVtxXgen' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:323:36: error: variable 'mapVtxYgen' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:324:36: error: variable 'mapVtxZgen' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:325:36: error: variable 'mapMcCollIdPerRecColl' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:327:8: error: constructor does not initialize these fields: pdg, ccdb, gCurrentHadronicRate [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:465:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:568:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:591:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:604:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:1140:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:1156:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:1197:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:1209:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:1375:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:1413:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:1428:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:1442:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:1479:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:1651:27: error: the parameter 'atrack' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:1687:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:1687:39: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:1688:23: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:2049:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:2104:23: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:2284:11: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:3576:22: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:3685:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:3811:27: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:3830:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:3888:26: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:3891:26: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:3894:26: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:3897:26: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGMM/Mult/Tasks/dndetaMFTPbPb.cxx:3907:26: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@gbencedi
gbencedi marked this pull request as draft July 17, 2026 18:53
@gbencedi
gbencedi marked this pull request as ready for review July 18, 2026 19:38
@alibuild

alibuild commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 1b07fca at 2026-07-18 22:41:

++ set -euo pipefail
++ [[ -d /sw/slc9_x86-64/Clang/v20.1.7-23 ]]
+++ realpath /sw/BUILD/fc8d224c1578f0abbc49b4905e5a693ef4e17886/O2Physics-code-check/../../O2Physics-latest/O2Physics
++ O2PHYSICS_BUILDDIR=/sw/BUILD/f5bcaede9844d57a35321666825cb778c4b1fd72/O2Physics
++ cp /sw/BUILD/f5bcaede9844d57a35321666825cb778c4b1fd72/O2Physics/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonpath([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2PHYSICS_SRC=/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0
++ pushd /sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0
/sw/SPECS/slc9_x86-64/O2Physics-code-check/1.0-local106/O2Physics-code-check.sh: line 16: pushd: /sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0: No such file or directory

Full log here.

@gbencedi
gbencedi enabled auto-merge (squash) July 18, 2026 20:03

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @gbencedi.

@gbencedi
gbencedi merged commit cb8903c into AliceO2Group:master Jul 18, 2026
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants