Repository navigation
AutoAttack using Patch + SelectBestTarget for "Many" - #1533
Merged
Merged
Conversation
Collaborator
Author
|
I need to adjust some little things on this PR, reported by @Tirlititi. I will do that when my Internet will be back.... ^^ don't merge it please. |
Tirlititi
marked this pull request as draft
October 8, 2026 21:36
Albeoris
reviewed
Oct 9, 2026
DV666
marked this pull request as ready for review
October 9, 2026 18:20
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm suggesting these two small improvements (based on feedback from my Trance Seek mod):
AutoAttackoption, characters used theAttackcommand by default.However, I’ve proposed a fix so that it takes
AbilityFeatures.txtinto account, in case theAttackcommand is using[code=Patch](e.g., Vivi’s Magic Scepter in Trance Seek).SelectBestTarget.For example, a
Lifespell set toManyAnycannot benefit from smart targeting and may hit the first character, who isn’t necessarily KO’d.I’ve tested it and think it’s safe to add
Manytargets like.