Skip to content

AutoAttack using Patch + SelectBestTarget for "Many" - #1533

Merged
DV666 merged 6 commits into
Albeoris:mainfrom
DV666:LittleImprovements
Oct 9, 2026
Merged

DV666 merged 6 commits into
Albeoris:mainfrom
DV666:LittleImprovements

Conversation

@DV666

@DV666 DV666 commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

I'm suggesting these two small improvements (based on feedback from my Trance Seek mod):

  • Under the AutoAttack option, characters used the Attack command by default.
    However, I’ve proposed a fix so that it takes AbilityFeatures.txt into account, in case the Attack command is using [code=Patch] (e.g., Vivi’s Magic Scepter in Trance Seek).
  • I also suggest adding additional targeting options for SelectBestTarget.
    For example, a Life spell set to ManyAny cannot benefit from smart targeting and may hit the first character, who isn’t necessarily KO’d.
    I’ve tested it and think it’s safe to add Many targets like.

@DV666

DV666 commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator Author

I need to adjust some little things on this PR, reported by @Tirlititi.

I will do that when my Internet will be back.... ^^ don't merge it please.

@Tirlititi
Tirlititi marked this pull request as draft October 8, 2026 21:36
Comment thread Assembly-CSharp/Global/battle/BattleHUD/BattleHUD.cs Outdated
Comment thread Assembly-CSharp/Global/battle/BattleHUD/BattleHUD.Unity.cs
@DV666
DV666 marked this pull request as ready for review October 9, 2026 18:20
@DV666
DV666 merged commit a1c2166 into Albeoris:main Oct 9, 2026
1 check passed
@Tirlititi

Copy link
Copy Markdown
Collaborator

Thanks

@DV666
DV666 deleted the LittleImprovements branch October 9, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants