Repository navigation
fix: Firefox 自動調整 ruby 字級愛扣掉地區變體標籤个寬度 - #254
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01RbbWdj4FFAC78XyYbda719
Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01RbbWdj4FFAC78XyYbda719
|
Review 整體:改動小、方向正確。Firefox 下變體行 ruby 左爿有 .variant-label 摎 flex gap,原本 availableWidth 無扣,這下扣掉合理。註解有跟專案慣例,index.html 也有 bump 查詢字串。 建議
無安全性問題。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
四縣、饒平地區變體標示推出後,Firefox 自動縮 ruby 字級既流程無算著變體行左爿个地區標籤(badge),導致畫面又被撐寬。
原因
adjustRubyFontSize(main.js)只拿 td 寬度摎單一 ruby 寬度比較,無扣掉.variant-label个寬度摎 gap,縮出來个字級還係忒大。修正
.variant肚時,可用寬度先扣掉.variant-label个寬度摎 gap。index.html个main.js版本號更新到?v=4.5.46,避免舊快取。驗證
node --check main.js通過。🤖 Generated with Claude Code
https://claude.ai/code/session_01RbbWdj4FFAC78XyYbda719