Add Retry-After to rate-limited responses - #355
Open
teta2k wants to merge 1 commit into
Open
Conversation
teta2k
marked this pull request as ready for review
August 6, 2026 16:01
Summary by Aikido
⚡ Enhancements
📚 Documentation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry-Afterheader to the default 429 rate-limit responsetime_remainingvalue for the delayRoot cause
The rate limiter already attached the remaining window to
request.env["aikido.rate_limiting"], but the default responder discarded that information and returned onlyContent-Type. As a result, clients received a 429 without knowing when to retry.Custom
rate_limited_respondercallbacks are unchanged.Validation
test-rate-limiting-retry-after: passed in 5.05 seconds against the latest Ruby demo app using this branch as a local path dependencyBefore this change, the same Compose test reported five rate-limited responses without a
Retry-Afterheader.