[Aikido] Fix 26 security issues in activestorage, nokogiri, rails-html-sanitizer and 3 more - #348
Open
aikido-autofix[bot] wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies to fix critical arbitrary file read and RCE vulnerabilities in Active Storage libvips handling, plus Nokogiri canonicalization bypass and memory leak issues.
✅ 26 CVEs resolved by this upgrade
This PR will resolve the following CVEs:
canonicalizemethods returns empty string instead of raising an exception, allowing downstream libraries to accept invalid XML and bypass signature validation in SAML implementations.do_xincludefreed nodes and namespaces that were already exposed to Ruby, leaving objects pointing at freed memory and causing potential invalid reads/writes. This affects CRuby only when XInclude is called after traversing the document tree..allocate, causing process crashes. This requires direct misuse of the API and cannot be triggered by untrusted input.Document#root=, potentially causing segfaults or invalid memory reads. The vulnerability requires programming error and cannot be triggered by untrusted input.<use>. This permits attackers to inject malicious scripts through SVG local references.hrefattributes to reference external documents and potentially execute scripts or load external content for tracking purposes.hrefattribute on SVG elements, allowing Cross-site Scripting (XSS) attacks through external document references in elements like<use>and<feImage>. This enables arbitrary script execution or external content loading when sanitizing user-supplied SVG.javascript:alert(1)to bypass filtering and execute in browsers.allowed_uri?helper fails to rejectjavascript:URIs when the scheme is split by HTML5 named character references like	or
, allowing attackers to bypass URI validation and execute arbitrary JavaScript. This affects callers of the public helper method and higher-level features like Action Text markdown link validation that render approved URIs into HTML attributes.partial_value, which reads freed memory through stale state pointers.create_functionordefine_function.🔗 Related Tasks