Repository navigation
fix(tui3): blanks foot giveUp + refresh standing count on stood - #821
Merged
Merged
Conversation
[tab] next blank was ranked sixth on the room foot, so at a hundred columns (the e2e gallery width) a blanks page gave up the only key that walks the holes. Rank it with the answers, same law as checklist tick it. A stood update from ask-here or this conversation left keepingCount's cached zero until the next beat; refreshKeepingCount drops it so ◦ N standing orders reaches the task-column foot and /status with the news. Co-authored-by: Santosh kumar <[email protected]>
Co-authored-by: Santosh kumar <[email protected]>
santoshkumarradha
marked this pull request as ready for review
September 10, 2026 22:45
santoshkumarradha
deleted the
santosh/chrome-standing-questions-7c8b
branch
September 10, 2026 22:45
santoshkumarradha
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two chrome reds that are not news/handover/retarget:
TestQuestionsE2E/[tab] next blank— product regression:next blankhadgiveUp: 6, so at 100-col e2e gallery width the foot kept[c] change/[x] compareand dropped the blanks verb (same class as checklisttick it/ Questions: the wave proved end to end, with pictures — and six things it does not yet reach a person with #765). Ranked with answers (giveUp: 0).TestTUIE2E/the_firing_reaches_the_person/◦ N standing orders— chrome lives on the task-column foot (and/statusunderwatching), not the status row (Chat foot: identity on the seam, a ledger row, the live rate over the wire, and home's target #747). A stood event leftkeepingCount's cached zero until the next beat;refreshKeepingCount()now runs on stood updates (conversation + errand).· you ·receipt spelling was already fine; blanks failed earlier in the suite.Files
questionkeys.go,questioninput_test.gostanding.go,homeexchange.go,homestanding.go,homestanding_test.gochatv3_host.go,questions.md,keeping-an-eye.md,tuiwords_test.godocs/changes/unreleased/821-chrome-standing-questions.mdVerify
Live tagged e2e not run in the agent pod (no API key).