Repository navigation
e2e: roomfeed Took journal + checkout guard vs live neighbour - #820
Merged
Merged
Conversation
…rge trees Organized rooms at the e2e 120x40 frame drop the legend's `room ·` spelling and put `esc/← main` on the focus header — wait for that. The hermetic checkout guard no longer fails shared-box runs on a neighbour aforge's task/ branches and .aforge-v3/ worktrees when TMPDIR is outside the tree. Co-authored-by: Santosh kumar <[email protected]>
After the room opens, a landing folds per-call durations behind the worked chip; open it. Shorten the scripted bash args so toolTail still leaves room for 3.0s / 7.0s on the row. Co-authored-by: Santosh kumar <[email protected]>
…it ran EventToolFinished already carried the figure live; a room opened after landing replayed Args and Output with no duration. Write a took line keyed by call id, thread it through DisplayEntry and replayBlocks, and keep the roomfeed needle on roomBackWord plus an opened worked chip. Co-authored-by: Santosh kumar <[email protected]>
Co-authored-by: Santosh kumar <[email protected]>
Co-authored-by: Santosh kumar <[email protected]>
The new per-call duration line is a session fact, not a message, and sub-millisecond finishes must not write a 0ms took entry.
santoshkumarradha
marked this pull request as ready for review
September 10, 2026 23:00
santoshkumarradha
added
the
area:tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the roomfeed duration needle and session checkout-guard false reds when another aforge is live on the same tree.
Root causes
room ·wait (suite) — with the rail open, an organized room showsesc/← mainon the header and an empty legend left; waiting forroom ·never matches. Tests now assert the open organized chrome.Tooklived only on liveEventToolFinished. Journal now persists atookline keyed by call id so replay shows figures after landing.task/branches and.aforge-v3/worktrees were treated as this run’s writes. When TMPDIR is outside the tree and another aforge is using the checkout, that churn is ignored; HEAD/porcelain stay watched.Also
reading-a-task-pageupdated for the duration-on-reopen behaviour.docs/changes/unreleased/820-roomfeed-checkout-guard.mdOverlap note
Related to #819 (broader reliability wave). Reviewers should check whether this PR supersedes, extends, or should stack on #819’s roomfeed/checkout commits before merge.
Verify