Repository navigation
Let tasks search and read earlier conversations directly - #769
Merged
Merged
Conversation
Member
Author
|
Owner’s standing instruction for every session: final end-to-end tests, full affected-package suites, and pre-merge acceptance must run on Spark through fleet, never on the laptop. The global Claude and Codex instructions already contain this rule; repository instructions are being aligned in #775. A local full package run from this worktree was observed during the audit and has since ended. Please use Spark for subsequent full acceptance runs, retain the remote job ID and exact tested revision/snapshot, and do not fall back to the laptop if Spark is unavailable. Small focused local checks do not replace remote acceptance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A request to find an earlier conversation could send the model through repeated task searches and filesystem discovery. Task workers had a more basic problem: their toolbelt omitted conversation search because they inherited no writable memory store.
This change grants read-only indexed history to workers, nested workers, forked hands and task checkers.
search_conversationssearches across projects with SQLite FTS5 BM25, browses a known conversation, and opens original indexed messages through copyable source references. Match-centred excerpts, nearby messages, stored roles and dates expose evidence and corrections. Broad searches exclude the requesting thread; explicit scope and parent-history access remain available. Memory writes and background extraction are not inherited.Live experiments also exposed missing checker context. A fallback contract saying “Complete the brief” now includes that referenced brief. The checker is told that a requested final response is a retained deliverable; its facts still need evidence, and required or claimed files still must exist. The schema, prompt, task-miss guidance, built-in manual, performance limits and change entry are updated together.
Validation and merge readiness:
history769tested an isolated checkout. The batch job20260910-033823-000395was cancelled when the owner explicitly chose a separate persistent Spark terminal.1350aed0b4f36d4d33f519788aeefe75ce5bc370:make build,make test-quick, and fresh full store/session/manual/e2e/tui3 suites passed on Spark. Session: 197.403s; tui3: 419.092s.57fe632abd13fb4e86702f1e7af2c953ba61761ddiffers only in the tagged E2E test: human badge labels tolerate display capitalization while source receipts remain exact; discovery-query counts are separated from distinct source reads. Duplicate calls, missing evidence, wrong answers and filesystem detours remain failures.go test -tags e2e -count=1 -timeout 15m -v -run '^TestConversationSearch' ./internal/e2e. All six live DeepSeek V4 Flash scenarios passed in 97.945s. The actual task returned the correct cited answer and finished done, with two worker lookups and two checker lookups.spark:/home/santosh/bench-artifacts/history769/. Final log SHA-256:fdce0f607e8adab3d025b66e6bc2024867af79187dc67cf34fb62f1dcdb03473.Retrieval remains lexical and limited to indexed messages in this store. These live tests exercise the engine and real task/checker loop, not the tmux terminal suite. Earlier redundant reads and broader file-delivery findings remain documented; no universal recall or answer-quality guarantee is claimed.
Architecture, experiment iterations, reproducible commands and remaining limits.