Repository navigation
fix: make dev's Full check green (promotion tests, archived relay client, run-row ordering) - #2077
Merged
Merged
Conversation
…ow and docs ship #1922 rewrote TestC16PromotionTriggerAndCutoff to want explicit dispatch only and dropped the explanation the workflow still carries, while promote-staging.yml and docs/rules/promotion.md kept the Friday 17:00 Toronto schedule. The tests now pin that shipped contract; dev's Full check has failed on them since 2026-10-25. Co-Authored-By: Claude Opus 5.5 <[email protected]>
TestR25ArchivedPreconditionalClient builds an older client from a temporary folder, where Go's VCS stamping fails (error obtaining VCS status), so the test has failed in every Full check since #1950 added it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…Close joins it publishRunRow emitted the settled task update before keeping the run row and indexing it, and Close did not wait for a run that had already ended, so a caller that closed on the announcement raced the index write: the driver recreated tasks.jsonl and its lock in a closed session's bucket. In CI that surfaced as the run-spend tests failing TempDir cleanup since 2026-10-28. The row is now persisted first, Close joins a run whose engine has already answered (bounded by closeGrace), and late index writes after close are declined. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full checkondevhas failed every day since 2026-10-23. Three causes, each fixed on the side that was wrong:TestC16PromotionTriggerAndCutoff,TestPromotionWorkflowExplainsItsSafetyLawsdocs/rules/promotion.mdand CLAUDE.md all ship the Friday 17:00 Toronto scheduleTestR25ArchivedPreconditionalClientTestStartTaskBashBeltFoldsRunDollarsOnceOnEveryEnding,TestARunsSpendIsFoldedIntoTheConversationAndNotTheRunningTurn,…RunSpendRefusesNextTurn…publishRunRowannounced a settled run before persisting it andClosedidn't join an ending run, so the driver recreatedtasks.jsonl/its lock in a closed session's bucket (TempDir cleanup failed)Closejoins an already-answered run (bounded bycloseGrace), late index writes after close are declined; new regression testTestSettledRunRowIsRecordedBeforeTaskUpdateAndJoinedOnCloseLatent since #1627; widened into a consistent failure by the checkpoint locking in #1944/#1990 (bisected at each commit).
Verified:
internal/release,internal/relayserve(targeted), focusedinternal/sessionoverBelt|RunSpend|RunsSpend|SettledRun|Close|TaskIndex|Quit|StartTask,make test-laws, build, vet, gofmt.🤖 Generated with Claude Code