Repository navigation
senior-dev: a pass that ran no command says so, instead of that the build and tests passed - #1801
Open
ZeroPoint95 wants to merge 3 commits into
Open
ZeroPoint95 wants to merge 3 commits into
ZeroPoint95 wants to merge 3 commits into
Conversation
…ests passed
A real run in a folder holding only a README ended
senior-dev finished: submitted a change, and the project's own build and tests passed
senior-dev observed: the project has no build or tests it could find to run
because messageOf read the inner status and never the count of commands
behind it. A folder that does not look like a project has nothing for
discovery to find, so its check comes back clean having run zero commands.
The ending now says "submitted a change; the project has no build or tests
it could find to run" in that case, in the same words the observation uses
(one constant, nothingToCheck), and keeps the old sentence when at least one
command ran. The run's longer reason, which codeaf appends to the landing
note, made the same claim ("submitted, and its build and tests passed") and
now says "submitted, and found no build or tests to run".
The chat manual quotes the sentence only where it is true, gains a section
for a folder with nothing to run, and a test proves that section is reached.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
The manual's new section now says the chat still counts such a run as passed and offers to merge it without a check of its own, so the person should look at the change first. messageOf reads verification_commands the way observedOf does, telling absent from zero. The end-to-end test spells its expected sentences as literals, so on dev it fails on an assertion rather than failing to build. Co-Authored-By: Claude Opus 5.5 <[email protected]>
ZeroPoint95
marked this pull request as ready for review
October 9, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Makes senior-dev's ending say what was checked when its check ran no commands, instead of saying the build and tests passed.
submitted a change, and the project's own build and tests passed, and the line under it saidthe project has no build or tests it could find to run.submitted a change; the project has no build or tests it could find to run.nothingToCheck), so they can't drift.submitted, and its build and tests passed. It now sayssubmitted, and found no build or tests to run.pass. Exit codes and codeaf's classification are unchanged.Manual (
internal/manual/chat/senior-dev.md)finished: …bullet in "Why did senior-dev stop" now covers a run that found nothing to run.chat_test.gogains a test that four questions in a person's own words reach the new section.Not in this PR
passed(programVerdictOf,internal/session/program_outcome.go). The manual section says so.How it was checked
go test -count=1 -run '^(TestPassEndingSaysOnlyWhatWasChecked|TestFolderWithNothingToRunEndsWithoutSayingItPassed)$' ./internal/seniordev/app/dev'srun.goandsolo_ship.go, both fail on assertions:message = "…build and tests passed", want "…no build or tests it could find to run", and the second also onreason = "submitted, and its build and tests passed: …".go test -race -count=1 ./internal/seniordev/app/ ./internal/seniordev/: ok.go test -count=1 ./internal/manual/andmake test-packed-manual: ok (includesTestSeniorDevNothingToRunQuestionsReachItsSection).go run ./cmd/codeaf-changes check: 19 entries, all well formed.Checklist
docs/changes/unreleased/1801-senior-dev-ending-no-checks.md.internal/manual/chat/senior-dev.mdupdated in this change..github/known-red.txt.🤖 Generated with Claude Code