Repository navigation
chat: restore connected accounts in standing firings - #1715
Closed
ZeroPoint95 wants to merge 1 commit into
Closed
ZeroPoint95 wants to merge 1 commit into
ZeroPoint95 wants to merge 1 commit into
Conversation
v3StandingPosture built session.Config without Connect, so a firing's session.connect hub was nil and `services`/`use_service` were missing from every standing task even when the account was connected. Live conversations already inject proc.Conns, derived once per process by v3Connect. v3StandingPosture and v3StandingTicker now take the accounts manager as a parameter. The live window's tick loop passes p.Conns, so the firing reaches the very object the surface and every conversation hold and the two never keep separate caches over one connect store. The detached `codeaf tick` has no process to borrow from, so it resolves the profile's manager once before it builds its pass. Nil stays nil: a firing with no manager still carries no account tool rather than one fabricated to fill the gap. Three behavioral tests drive the ticker's Runner probe path: the caller's manager is handed back unchanged, a connected-manager firing reaches `services`, and a nil-manager firing reads "Unknown tool: services". Assisted-by: CodeAF (deepseek-v4.1-flash) Co-Authored-By: CodeAF <[email protected]> (cherry picked from commit 4c9f0ecae198fd02f297df300501a743b58b5f1b)
santoshkumarradha
added
bug
santoshkumarradha
added
area:provider
santoshkumarradha
force-pushed
the
dev
branch
from
October 24, 2026 21:53
a2f0486 to
d68bcf8
Compare
santoshkumarradha
force-pushed
the
fix/standing-connected-accounts
branch
from
October 24, 2026 21:54
17b1f9c to
4a86386
Compare
Collaborator
|
Thanks for spotting the missing connected-account context and testing both the shared-manager and nil-manager cases. Standing orders, and the ticker this changes, were replaced by automations in #1831. Today's clock uses the common conversation assembly with its single process account manager, and focused checks on dev and app/v3 confirm the services probe works with that manager and stays absent when it's nil. Closing this as obsolete, since the replacement path already covers it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Standing firings now inherit the live window’s connected-account manager, while detached ticks open the profile manager for their pass. Behavioral tests cover tool availability and nil-manager absence. The existing 15-minute Notion automation is unchanged.
Checks
make build: passed.make pr-ready: failed on existing macOS/private/var/foldersversus/var/folderspath assertions in fivecmd/codeaftests. An isolated earlier run also hit three such assertions ininternal/session. No standing-account test failed.This PR remains draft until the gate is green; the deployed automation is not yet restored.
—
Drafted with CodeAF · reviewed and owned by the author