Repository navigation
tasks: a stopped run names the work its worker already committed - #1710
Merged
Merged
Conversation
A stopped run read only paths committed from its current index, so a worker that had already committed its files could be reported as having changed nothing and its retained branch was omitted from the receipt and row. Read committed work against the run's original base before keeping pending edits. Share the landing's history rule, preserve the deliberate omission of empty branches, and keep the person's checkout untouched. Add regression coverage through real repositories and a real session.Agent, and document that already committed work counts in a stopped run. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
AbirAbbas
marked this pull request as ready for review
October 1, 2026 02:05
santoshkumarradha
added
the
area:session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Stopping a run whose worker had already committed its work said
stopped · it had changed nothingand named no branch. The re-verification pass over dev stopped a 20-item FAQ task after its commits had landed. The branch held 20 commits, and the card said nothing changed. The work was safe, but the person was told it did not exist. This is already in v0.5.0:stoprun.gopassed no committed paths intokeptWork, and only uncommitted edits were counted.What is true now
The stop receipt and the row count the work already committed on the task branch since the run's base (
checkBase), plus anything still uncommitted. They use the same history rule landing already uses (runCommittedPaths), so the receipt readsstopped · its work so far is kept on <branch> and did not go into <folder> · merge that branch to bring it in, or delete it to drop it. A run that truly changed nothing still says so and names no branch (TestAStoppedRunThatChangedNothingSaysSo, unchanged).Proof
TestAStoppedRunNamesWorkTheWorkerAlreadyCommittedcovers committed-only work and committed-plus-pending work.TestAStoppedRunNamesCommittedThenRevertedWorkcovers the revert case. Both use real repositories, task branches andsession.Agent.Cancel, and fail before the change.2f33722b2says "it had changed nothing" with 21 commits on the branch. This branch shows the kept-work receipt, the files and the branch, in both the chat card and the task room.worker-harness.mdmanual is updated. An independent read-only review returned "ready".🤖 Generated with Claude Code