Fix expansion filter for content added in later patches - #2499
Open
DWalland wants to merge 3 commits into
Open
Conversation
DWalland
marked this pull request as draft
August 16, 2026 01:48
Add logic to keep non-collectible containers traversable for mixed-expansion content.
Author
|
After some testing i still found some items where you needed to have two expansion filters enabled for them to show up. (Like guild mount/tabards from MoP was under the Cata 'Guild Vendor' category. Or 'Chamber of Heart from BfA which was under 'Silithus: The Wound' from Legion.) Now it filters based on the leaf/end items expansion. |
DWalland
marked this pull request as ready for review
August 16, 2026 02:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the Retail expansion filter to prefer an object's
expansionIDbefore falling back to awp value.Problem
Some content belongs to an older expansion but was added or reworked in a
later expansion's patch.
For example, for Siege of Orgrimmar loot to show up you need to have both the MoP and WoD filter on.
some of its difficulty data has
awp=60002because it was added with the Warlords ofDraenor pre-patch. The expansion filter interpreted that value as WoD content.
As a result, Siege of Orgrimmar was hidden when:
This also fixes #2344 where Legion content shows up if all filters are disabled.
Fix
When an object is nested under an expansion wrapper, the filter now uses the
inherited
expansionIDto determine visibility. For objects without anexpansion wrapper, it retains the existing
awp-based fallback.This means Siege of Orgrimmar correctly follows the MoP filter without
changing the behavior of unscoped content.
Verification
Scope
This applies to nested content generally, not only Siege of
Orgrimmar. The containing expansion identifies the content's expansion
ownership, while
awpidentifies when a particular object was added orreworked.