Add a sharding-aware implementation of muon to Maxtext. - #4936
Open
copybara-service[bot] wants to merge 1 commit into
Open
Add a sharding-aware implementation of muon to Maxtext.#4936copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
This implementation uses all-to-all on specific layers to reduce overhead. It also removes the vmap over batch axes and replaces it with a generalized einsum. Unlike most optax optimizers, this implementation requires a full sharding tree, in order to effectively use operations like jax.lax.with_sharding_constraint to constrain sharding of intermediate tensors. PiperOrigin-RevId: 966768307
copybara-service
Bot
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
shuningjin,
vipannalla and
xibinliu
as code owners
August 18, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a sharding-aware implementation of muon to Maxtext.
This implementation uses all-to-all on specific layers to reduce overhead. It also removes the vmap over batch axes and replaces it with a generalized einsum.
Unlike most optax optimizers, this implementation requires a full sharding tree, in order to effectively use operations like jax.lax.with_sharding_constraint to constrain sharding of intermediate tensors.