Fix duplicate XLA compilation of jit(train_step) - #4934
Open
olupton wants to merge 1 commit into
Open
Conversation
The AoT compilation used to extract memory stats previously caused a redundant compilation due to mismatched context managers. Skip the memory stats entirely when AutoPGLE is enabled as there is no nice way of getting the statistics up-front without causing redundant compilation.
olupton
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
shuningjin,
vipannalla and
xibinliu
as code owners
August 18, 2026 14:58
There was a problem hiding this comment.
Code Review
This pull request removes the legacy mesh context manager from the training loop to prevent double compilation of train_step, and skips ahead-of-time compilation when AutoPGLE is enabled to avoid redundant compilations. The review feedback suggests using getattr when checking jax.config.jax_enable_pgle to prevent potential AttributeError crashes on older JAX versions or unsupported platforms.
NuojCheng
reviewed
Aug 18, 2026
| # Do not enter the legacy `mesh` context manager here: the training loop calls | ||
| # p_train_step without it, and the mismatch in jit's tracing-cache key would | ||
| # cause train_step to be traced and compiled a second time on the first step. | ||
| with jax.set_mesh(mesh), nn_partitioning.axis_rules(config.logical_axis_rules): |
Collaborator
There was a problem hiding this comment.
@khatwanimohit is the diloco implementation still blocked by this?
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The AoT compilation used to extract memory stats previously caused a redundant compilation due to mismatched context managers. Skip the memory stats entirely when AutoPGLE is enabled as there is no nice way of getting the statistics up-front without causing redundant compilation.
Tests
With https://docs.jax.dev/en/latest/config_options.html#jax_log_compiles this can be seen to reduce the number of training step compilations from 2 to 1 without AutoPGLE, or from 3 to 2 with AutoPGLE.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.