Repository navigation
fix(afl_stats): report execs_per_sec as a rate instead of total execs - #3939
Open
Aditya30ag wants to merge 1 commit into
Open
Aditya30ag wants to merge 1 commit into
Aditya30ag wants to merge 1 commit into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AflStatsStagewrote the total execution count intoexecs_per_sec, sofuzzer_statsand everyplot_datarow showed a number that only grows instead of throughput.Fix
Keep the previous
(time, executions)sample and report the rate between stats reports. The first report has no baseline and yields 0. Zero elapsed time and a counter that goes backwards also yield 0.Testing
baby_fuzzer_unicodefor 20s withstats_file/plot_fileset:execs_per_sec==execs_done(323253)execs_per_sec≈ 25k, matching 501813 execs / 20sChecklist
./scripts/precommit.shand addressed all comments