Skip to content

feat(ui): VeriFrame rebrand, full UI overhaul with motion, and public home page - #20

Merged
ADITYASINGH1206 merged 1 commit into
mainfrom
feat/veriframe-ui-overhaul
Oct 29, 2026
Merged

ADITYASINGH1206 merged 1 commit into
mainfrom
feat/veriframe-ui-overhaul

Conversation

@ADITYASINGH1206

Copy link
Copy Markdown
Owner

What this changes

Rename. SENTINEL-V is now VeriFrame everywhere a user sees it: the web app (single source web/src/brand.ts), page titles, favicon, OpenAPI title, the HTML and PDF case report headers, README and docs. Internal names are deliberately kept so nothing breaks (ADR 007): sv_* packages, SV_ settings, the sv-receipt/1 format, and the /compat contract used by SENTINEL.

Home page (/).

  • Animated scan illustration, original SVG only; the loop pauses when off-screen.
  • "How it works" pipeline and a feature grid.
  • Base-rate calculator using the S-MSDT paper's test-split operating points, with the source cited.
  • Verify teaser, research and known-limitations section, FAQ.

Console (/app).

  • Collapsible animated sidebar, breadcrumbs, page transitions, and a theme toggle (system / light / dark) with no flash on load.
  • New pages: Dashboard, Analyze, Cases, Case, Review queue, Review workspace, Policies (presets plus simulator), Settings.
  • Analyze does uploads with real progress, or URL submission.
  • Cases keeps its filters in the URL and exports CSV.
  • BrowserRouter with lazy route chunks; old #/...; links redirect.

Honest data.

  • Uses the live API first.
  • Where an endpoint does not exist yet (case list, review queue) or the API is unreachable, it shows generated demo data with a persistent DEMO DATA badge and banner. Real analysis IDs never fall back to demo data.
  • Demo scores are computed from the Stage B calibration. The demo video is a synthetic abstract face; it contains no real person.
  • Removed the invented "Avg Triage Speed" metric and the hard-coded case values.

Fixes found while rebuilding the UI.

  • Review form: it now sends what the API accepts (authentic | manipulated | cannot_tell, reasons, required confidence) and shows HTTP errors. Before, a 422 was reported as "recorded".
  • Verifier – signature: it only passes when a public key actually verified it. Before, a receipt with a key ID but no embedded key passed without being checked.
  • Verifier – other checks: a Merkle root with no proof, an anchor transaction that was not looked up, and registry fields are now shown as "skipped", not "pass".
  • Verifier – hashing: video files are hashed in 8 MiB chunks instead of being loaded into memory.
  • Evidence player: it uses real face-box geometry, with correct letterboxing. The patch grid is drawn only for demo data, and labelled.
  • Docker: the web image now serves the app from nginx on port 8080, with an SPA fallback and proxying for /v1, /compat, /readyz and /.well-known; SSE is not buffered. Compose maps 5173:8080.

Docs.

  • ADR 007 (rename) and ADR 008 (design system, motion, demo-data policy).
  • docs/design/tokens.md, with measured contrast ratios; every pair meets WCAG AA.
  • docs/design/motion.md.
  • CHANGELOG entry.
  • New blockers B9 (rename the GitHub repo) and B10 (name-availability check).

Test results

  • npx tsc --noEmit: clean
  • npx vitest run: 26 passed (4 files)
  • npm run build: clean bundle build with chunk splitting
  • Ruff lint & format: all clean
  • Mypy type check: clean

@sourcery-ai

sourcery-ai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Sorry @ADITYASINGH1206, your pull request is larger than the review limit of 150,000 diff characters

@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

🤖 SENTINEL-V DeepForensics AI Review

Status Target PR Author Review Engine
[VERDICT_BADGE: ✅ APPROVE] #20 - feat(ui): VeriFrame rebrand, full UI overhaul with motion, and public home page @ADITYASINGH1206 Google Gemini DeepForensics

📋 1. Executive Summary

This Pull Request rebrands the SENTINEL-V platform to "VeriFrame" in all user-facing components, aligning with ADR 007. It introduces a comprehensive UI overhaul for the web application, including a new public home page, a redesigned console with enhanced navigation and features, and a restyled public verifier. Significant architectural changes include migrating the web app to BrowserRouter with Nginx serving static assets and proxying API requests, and a robust motion design system (ADR 008). The PR also introduces a synthetic demo video and explicit "DEMO DATA" badging to ensure transparency when the API is unavailable.


🛡️ 2. Specification & Policy Compliance Checklist

Rule / Invariant Status Details / Audit Finding
No Hardcoded / Invented Results ✅ Pass The PR explicitly removes the invented "Avg Triage Speed" metric and hard-coded case values. It introduces a VITE_DATA_MODE=demo option and "DEMO DATA" badges for synthetic data, ensuring transparency and adherence to the rule. Home page metrics are sourced from web/src/content/sourced/. The README update for E3 also clarifies that compute savings are measured rather than assumed.
Locked Core Untouched (Additive Only) ✅ Pass No modifications to core SENTINEL platform files or integrations/sentinel/ are observed. The rebrand is strictly user-facing and within the sv_api and web services.
Upstream Submodule Purity (smsdt) ✅ Pass The third_party/smsdt submodule remains untouched.
Forbidden Copy Compliance ✅ Pass The PR maintains compliance by avoiding forbidden terms like "FAKE", "REAL", "100%", "guaranteed", or "AI-certified". The mandatory screening disclaimer is implicitly handled by the UI design and the nature of the platform as an "aid."
Calibrated Probabilities & Decisions ✅ Pass The PR explicitly states that demo scores are computed using p_bal = σ(a·u + b) with Stage B calibration, and bands come from the strict-low-fpr preset, confirming adherence to calibrated probabilities. The new Policies page also includes a simulator.
Test Coverage & Parity ✅ Pass The PR adds 26 Vitest tests covering brand guard, calibration maths, demo-data consistency, 422 handling, and streamed hashing. This demonstrates strong commitment to test coverage for new logic.
Security & Sandboxing ✅ Pass The Nginx configuration includes client_max_body_size 500m for API proxying, which is a reasonable limit. The streamed hashing in the public verifier is a good practice for large files. No obvious SSRF risks, unsafe subshell executions (except for the make_demo_video.py script which is a dev tool, not runtime), or secret leakages are introduced.

🔍 3. Deep Forensic Findings & Vulnerability Analysis

🔴 [BLOCKING] Issues

None detected. The PR is well-executed and adheres to critical project rules.

🟡 [WARNING] Architectural & Code Quality Improvements

  1. Nginx proxy_read_timeout for SSE:

    • Path: infra/docker/nginx.conf
    • Line: 34
    • Explanation: While proxy_buffering off is correct for Server-Sent Events (SSE), a proxy_read_timeout of 3600s (1 hour) is excessively long for a typical SSE connection. If the backend API hangs or becomes unresponsive, Nginx will hold the connection open for an hour, potentially tying up resources. A more reasonable timeout for SSE, especially if the backend sends keep-alive signals, would be 60s to 300s. If the backend doesn't send keep-alives, the client should handle reconnections.
    • Suggestion: Consider reducing proxy_read_timeout to a more practical value, e.g., 120s or 300s, and ensure the backend sends periodic keep-alive messages if long-lived connections are expected.
  2. make_demo_video.py Error Handling:

    • Path: web/scripts/make_demo_video.py
    • Line: 100, 130
    • Explanation: The make_demo_video.py script uses subprocess.Popen and subprocess.run. While check=True is used for the WebM conversion, the initial MP4 conversion uses proc.wait() without explicitly checking the return code. If ffmpeg fails during the MP4 generation, the script will proceed to the WebM conversion with a potentially corrupted or missing input file, leading to a secondary error.
    • Suggestion: Add proc.returncode check after proc.wait() for the initial MP4 conversion to ensure ffmpeg exited successfully.
  3. Consistency in README for make dev:

    • Path: README.md
    • Line: 101
    • Explanation: The make dev command now maps 5173:8080 for the web service, but the "Visit the services" section still lists http://localhost:5173 for the web app. This is correct, but it might be slightly confusing that the internal port is 8080 while the exposed port is 5173. A small clarification could help.
    • Suggestion: Add a parenthetical note like (internal port 8080) to clarify the port mapping.

🟢 [VERIFIED] Strengths & Positive Highlights

  1. Comprehensive Rebranding & ADR Adherence: The rebrand to VeriFrame is meticulously applied across all user-facing elements (UI, API title, reports, docs) while respecting internal package names and existing receipt formats, as detailed in ADR 007. This demonstrates excellent architectural planning and execution.
  2. Robust UI Overhaul & Design System: The new UI, including the public home page, console layouts, motion policy (ADR 008, docs/design/motion.md), and design tokens (docs/design/tokens.md), is exceptionally well-structured. The use of framer-motion with MotionConfig reducedMotion and CSS data-motion attributes for accessibility is a best practice.
  3. Transparent Demo Data Handling: The introduction of a synthetic demo video, explicit "DEMO DATA" badging, and a VITE_DATA_MODE environment variable is a critical improvement for development, testing, and user understanding, directly addressing the "Never Invent Results" rule.
  4. Improved Web App Architecture: Migrating to BrowserRouter with Nginx for static asset serving and API proxying is a significant architectural upgrade, improving URL cleanliness, SEO, and overall deployment flexibility compared to HashRouter. The Nginx configuration is well-defined.
  5. Enhanced Test Coverage: The addition of 26 Vitest tests for new UI logic, branding, calibration, and hashing demonstrates a strong commitment to code quality and reliability.

💡 4. Actionable Next Steps

  1. Address Nginx proxy_read_timeout: Reduce the proxy_read_timeout for the /v1 API proxy in nginx.conf to a more appropriate value (e.g., 120s or 300s) to prevent resource exhaustion from hung connections.
  2. Improve make_demo_video.py Robustness: Add a return code check after proc.wait() for the initial MP4 ffmpeg command in web/scripts/make_demo_video.py to ensure successful video generation before proceeding.
  3. Clarify README Port Mapping: Add a small note in README.md under "Visit the services" to clarify the internal port 8080 for the web service, even though it's exposed on 5173.
  4. Complete ADR 007 Follow-ups: Ensure the GitHub repository rename (B9) and trademark check (B10) from docs/QUESTIONS.md are actioned as human tasks.

⚠️ Mandatory Screening Aid Notice: Screening aid — not proof. Human review required for consequential action.


5. Inline Actionable Suggestions (FOR CONVERSATIONS)

Comment thread README.md Resolved
Comment thread web/scripts/make_demo_video.py Resolved
Comment thread infra/docker/nginx.conf Resolved
Comment thread web/scripts/make_demo_video.py Resolved
@ADITYASINGH1206
ADITYASINGH1206 merged commit fe68b48 into main Oct 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant