Repository navigation
Closed tolerance table, external-force oracle on every robot, mimic wrench mapping - #15
Merged
Merged
Conversation
…t buckets, mimic-inclusive wrench mapping, external-force oracle over every robot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_tolerancerefuses an unknown algorithm key instead of returning the default bucket, and the module refuses a per-robot override whose algorithm has no bucket. GRiD's CUDA equivalence modules had passed keys this table never had (forward_dynamics,f_ext_grad,f_ext_grad_so,fd) and compared under the 1e-7 default; gen3's continuous-joint bucket therefore never applied and its pinocchio leg was left out of the external-force checks.forward_dynamicsandinverse_dynamics_gradientare algorithm-level buckets. The latter existed only as the gen3 override, so every other robot's gradient checks compared under the default with the same values. gen3 and h1_2 carry on forward dynamics the widening their inverse-dynamics buckets already have; no allowance changes for any existing check.scalar_joint_names, the list its f_ext gradient column already uses. Through the mimic-free list, h1_2's bodies after a mid-chain mimic joint received their neighbour's wrench and the mimic bodies none.tests/test_external_force_equivalence.py: inverse dynamics, forward dynamics, ABA and the inverse-dynamics gradients with a nonzero wrench on every body of every manifest robot, both bases, against pinocchio.tests/test_tolerances.py: the table is closed.Verification
--runslow -k "f_ext or external_force"): 72 passed.🤖 Generated with Claude Code