Repository navigation
fix(hq-ui): Giao việc groups sessions like the sidebar, disambiguates duplicate names (v0.92.1) - #42
Merged
Merged
Conversation
…tes duplicate names
Sessions started outside a registered project are grouped by the git folder
their office room reports ("su-code ⎇ main"), as the sidebar does, instead
of all landing under "Phiên khác". Two live sessions with the same name
show " · <8 id chars>" in the list, the fan-out chips and the summary line
so the owner can tell which one a task goes to.
Co-Authored-By: Claude Fable 5.1 <[email protected]>
Co-Authored-By: Claude Fable 5.1 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On live data every owner-started session fell under "Phiên khác" in the new Giao việc dialog (the sidebar groups them under "8sync-startup ⎇ main"), and duplicate names (two "rd" rooms, two "web" rooms) were indistinguishable.
What
lib/assign.ts:groupTargets(sessions, projects, rooms)— registered projects first, then git folders from/api/officerooms ("<name> ⎇ <branch>", case-insensitive root), then "Phiên khác".distinctLabels()adds· <8 id chars>to duplicate labels.assign-dialog.tsx: takesrooms; list rows, fan-out chips and the summary line use the distinct label.hq-app.tsx: passesoffice.office?.rooms.Verified
pnpm vitest run tests/assign-ui.test.ts11/11,tsc --noEmit,eslintclean (local, light).🤖 Generated with Claude Code