bug: tournament page re-fetches its static half every second - #587
Merged
Merged
Conversation
The tournament subscription selected branding, organizers, prizes, categories, match options, awards and award configs on every poll. The awards branch alone drags a nested tournament_team -> roster -> player join whose rows each cost an elo and three sanction lookups. Moves those to a one-shot query, merged back under the live half by a `tournament` computed so child components are unchanged. Organizer edit surfaces inject `refetchTournamentStatic` to refresh it, and the status watcher covers awards appearing when a tournament finishes. Also drops two player selections nothing renders: `captain` on tournament teams, and `elo` on award team rosters (podium hover passes show-elo="false").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tournament subscription pulled branding, organizers, prizes, awards and match options on every tick alongside the live data. Splits the static half into a one-shot query, merges both into a single
tournamentcomputed so children are unchanged, and refetches the static half when the status changes or an organizer edits it.Also drops a dead
captain: playerFieldsselection and takes elo off award rosters, which render withshow-elo=false.On prod this subscription family is 29% of top-level DB CPU across four variants.