perf: only fetch profiles for newly online players - #586
Merged
Merged
Conversation
Presence is pushed as a full roster, so any single connect or disconnect re-fetched every online player's profile -- elo plus three sanction checks each -- in every open tab. On prod that query is 15.6% of all database CPU. Cache profiles for the length of a session, ask only for steam ids not already held, and debounce the presence bursts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presence is pushed as a full roster, so any single connect or disconnect re-fetched every online player's profile — elo plus three sanction checks each — in every open tab.
On prod that query is the single largest database consumer at 15.6% of top-level DB CPU (242,840 calls over 31h, 281ms mean).
Caches profiles for the length of a session, fetches only steam ids not already held, and debounces the presence bursts.
Side effect:
playersOnlinenow clears when the roster empties, where it previously kept a stale list.