feature: shift+enter makes a new line in chat - #578
Merged
Merged
Conversation
Enter still sends and ctrl/cmd+enter still sends to the other room. The box grows to five lines and messages render their line breaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shift+Enter inserts a line break instead of sending, the way Steam chat and Discord behave. Enter still sends, Ctrl/Cmd+Enter still sends to the other room (match chat from team chat and back), and an Enter that is confirming an IME candidate never sends.
The single-line
<Input>became a<Textarea>that starts one line tall and grows to five. Messages render withwhitespace-pre-wrap, so the breaks survive.Pair with 5stackgg/api#410, which keeps a relayed message to one rcon argument — without it a newline in match chat would end the console command.
Tests: 99 (+5 for the key handling).