Skip to content

bug: queue player counts, friend button state, highlight self filter, name change notifications - #577

Merged
lukepolo merged 1 commit into
mainfrom
fix/fork-triage-bugs
Sep 18, 2026
Merged

lukepolo merged 1 commit into
mainfrom
fix/fork-triage-bugs

Conversation

@lukepolo

Copy link
Copy Markdown
Contributor

Web half of the fork-triage bug fixes. The queue count needs 5stackgg/api#409 to ship with it; the rest stand alone.

  • Queue count: the api sent one entry per queued lobby and the badge counted lobbies, so a queued trio read as "1 in queue". It now counts players, with multi-region lobbies still counted once. Counting lives in a tested helper.
  • Friend button: isFriend matched any my_friends row, including a still-pending one, so the hero showed the green "Friend" badge right after you sent a request — and again when someone sent you one. It now goes through useFriendActions: add / requested / accept / friend, with the in-flight state the rest of the app already uses.
  • Highlights: the player filter never offered you, so you could not filter to your own clips.
  • Name change notifications: the body was the one type rendered as plain text, so an api-escaped name showed up as '. It renders like every other type now (sanitized), and the notification shows the player card, so it links to the profile.
  • Teams: the owner no longer sees Leave. Nothing reassigned ownership, so leaving left the team owned by a non-member that only a site admin could manage. The database enforces the same rule in the api PR.

Tests: 98.

… name change notifications

- the matchmaking queue count counted lobbies, so a queued trio showed as 1
- the profile friend badge matched any my_friends row, so a pending request
  already read as "Friend"; the hero now shows add / requested / accept / friend
- highlights could not be filtered to your own clips
- name change notifications rendered their body as plain text, showing the
  escaped entities, and had no link to the player
- the team owner can no longer leave their own team
@lukepolo
lukepolo merged commit 41f8b86 into main Sep 18, 2026
2 checks passed
@lukepolo
lukepolo deleted the fix/fork-triage-bugs branch September 18, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant