Conversation
- a server that is behind the backend (restart, map reload) can no longer be resumed or publish rounds; it holds the match and restores the latest usable round on its own once the roster is whole - a restore requested while short-handed is queued instead of dropped, and .resume during a recovery votes to restore with whoever is here - backups are validated before upload and before restore: right round, and players in both PlayersOnTeam sections - a restore is verified, teams are re-enforced after it, and the in-memory round list no longer keeps stale duplicates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A restarted server came back at 0-0, could be resumed, and published its own round 1 over the real one. Restoring that backup gave 6v4 and the score on the wrong side.
.resumeduring a recovery votes to restore nowPairs with 5stackgg/api#419, which stops a recorded round from being overwritten.