Repository navigation
Hold the answered round until the share card is visible - #14
Open
justadreamer wants to merge 1 commit into
Open
justadreamer wants to merge 1 commit into
justadreamer wants to merge 1 commit into
Conversation
The share card ordering check counts finished rounds per animation frame, which cannot order a round and the card that land in the same frame. On a fast run the answered round finished 15 ms after the press, in the frame the card appeared, and failed the check twice in a row. Holding that request unsent until the card is visible, or 3 s have passed, makes a card that does not wait always visible first, while a card that waits still fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommonPath_ScriptThenPmp_Chromefailed twice in a row on the cloud release candidate (run): the answered round finished 15 ms after the press, in the same animation frame the share card became visible, so the per-frame count put the round before the card. The timeline can't order two events within one frame.Change: the timeline script now holds the request carrying
id.usageunsent until the share card is visible, or 3 s have passed. A card that doesn't wait on the refresh is then always visible before that round can finish. A card that does wait only appears after the hold gives up, by which time the round has finished, so the assertion still fails. Requests without an answer, and any request after the release, are not touched. BothfetchandXMLHttpRequestare covered, matching the client script's two transports.Testing: builds. The hold logic was exercised in Node with stand-in
fetch/XHR: answered requests are held until release or timeout, other requests pass through, and the path match is case-insensitive. The browser suite runs in cloud CI, where the release candidate's submodule points at this branch to validate it.