Repository navigation
FIX: Use the bespoke resource key for publish integration tests - #162
Merged
Merged
Conversation
GettingStartedWebCloudTest returns 503 on every Publish leg with SUPER_RESOURCE_KEY. _51DEGREES_RESOURCE_KEY_BESPOKE is the key the device-detection repos use for TestResourceKey/TestSuperResourceKey. Also declares the dryrun input publish.yml already referenced, so the workflow can be dispatched without pushing a tag.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Publish stage has been failing on every platform at
GettingStartedWebCloudTest.testWebCloud:94withexpected:<200> but was:<503>. The cloud-backed example cannot serve, which points at the resource key rather than the package._51DEGREES_RESOURCE_KEY_BESPOKEis the key the device-detection repos already use forTestResourceKey/TestSuperResourceKey. Noteci/run-integration-tests.ps1feeds this one secret to both-DTestResourceKeyand-DSuperResourceKey, so this changes the key for every cloud test in the suite.Changed:
publish.yml,nightly-pipeline.yml:TestResourceKeynow comes from_51DEGREES_RESOURCE_KEY_BESPOKE.publish.yml: declare thedryruninput the workflow already referenced. It was undeclared, so it silently evaluated to false and the workflow could not be dispatched without attempting to tag and release.Tested by dispatching Publish on this branch with
dryrun=true, which skips both the Maven Central publish (branch is not main) and the tag push.