Repository navigation
Conversation
…Align resource key and data file environment variables' Test helpers now check the aligned 51DEGREES_RESOURCE_KEY name (environment variable or system property) before the legacy TestResourceKey, and the aligned 51DEGREES_IPI_PATH name before searching the project space for a data file. Developer-facing messages and the README now reference the aligned names. Co-authored-by: Claude Fable 5 <[email protected]>
…nts, and constants were ported verbatim from device-detection-java and still reference device-detection-specific concepts (Hash algorithm, User-Agent, Client Hints, TAC) that have no relevance to IP Intelligence. Change where appropriate and deprecate items that aren't relevenat to ipi and aren't core to the solution.
…enclature # Conflicts: # ip-intelligence.shared/src/main/java/fiftyone/ipintelligence/shared/testhelpers/FileUtils.java
…enclature # Conflicts: # ip-intelligence.shared/src/main/java/fiftyone/ipintelligence/shared/testhelpers/FileUtils.java
Contributor
|
@Jamesr51d please compare with the changes in #126 - perhaps we want to add any missing changes from your PR into that one and merge that one? or vice versa, but then we need to fix conflicts here. Thanks |
Contributor
Author
|
closing as all changes are being merged and picked up in #126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Identifiers, Javadoc, test utilities and constants ported verbatim from
device-detection-java referenced concepts that have no meaning for IP
Intelligence (the Hash algorithm, User-Agents, Client Hints, TAC and
native model). Rename or remove them, with every renamed public main-source
type/member keeps a
@Deprecatedforwarder so client code gets a warning,not a compile error.
deprecated, extends the new one; the engine result still implements
it so existing casts keep working)
(old class kept as a deprecated empty subclass)
(old methods deprecated, delegating)
ip-intelligence-dotnet) in engine and builder
"IPIntelligenceOnPremise"
(IPIntelligenceAlgorithm {Hash, Pattern})
evidence.csv, which contains IP addresses); ClientHintsExampleTestBase
deleted (unused, pure DD); *Hash test classes -> *OnPremise;
Hash test methods -> OnPremise; IPIntelligenceTests now feeds
query.client-ip evidence instead of header.User-Agent
MultiIPIDataCloud "(e.g. TAC)", ci/README TAC/User-Agent wording
HardwareProfileCloudEngine + builder and MultiIPIDataCloud (the DD
hardware-profile/TAC lookup feature) and Enums.MatchMethods (DD Hash
match methods); removed the dead private matchMethods field from the
on-premise result class
ci/README documents IP_INTELLIGENCE_KEY and IPI_DATA_FILE_URL (the
secret the workflows already referenced) with the corrected distributor
URL (Type=IPIV41, Product=IPIV4Enterprise per common-metadata Products);
removed a device-detection documentation link from
setConcurrency Javadoc
Testing
Built and tested on JDK 11 / Maven 3.9, native engine compiled from the cxx submodules with MSVC v143 + Windows SDK 10.0.26100
Risks on Release
Out of Scope
Before Release