fix(release): macOS updater artifacts exist again, and their absence can never ship silently - #551
Merged
Merged
Conversation
…can never ship silently The v0.0.15-test rehearsal published a latest.json carrying only Linux and Windows, and the workflow called it a success. Two defects, one class: - bundle.targets explicitly listed nsis/dmg/appimage/deb/rpm — no 'app'. In Tauri v2 the macOS updater archive (.app.tar.gz + .sig) derives from the app target, so macOS produced installers but no updater artifacts, and the cross-job manifest merge had nothing darwin to merge. 'app' is macOS-only and ignored by the other bundlers; adding it restores the archives. - The required-artifact check tested that latest.json EXISTS, not that it is COMPLETE. A new fail-closed step parses the manifest and requires an entry with a non-empty signature for every released platform — a platform silently absent means those users never see another update, and that must block the release, not pass it. Negative-tested: the new check rejects the rehearsal's actual manifest (missing darwin-aarch64, darwin-x86_64) with exit 1. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01ENWj6RJtqDmcREYzMXXz5t
runyourempire
enabled auto-merge (squash)
August 30, 2026 06:05
runyourempire
added a commit
that referenced
this pull request
Aug 31, 2026
…he published release (#552) ## What The download page and vanity redirects (/download/<slug>/) were still generated from a hardcoded v1.0.0 entry in site/src/_data/release.js. productName changed `4DA Home` -> `4DA` in 1.0.1, so the templated asset names no longer exist on current releases — the buttons served the April build (or 404 shapes). ## How Regenerated via `.claude/tmp/update_site_release.cjs v1.0.2 --apply` — the generator discovers asset names from the *published* release and refuses when any installer is unmatched or ambiguous. All 6 installer URLs + sizes now match real v1.0.2 assets: - 4DA_1.0.2_x64-setup.exe (~120 MB) - 4DA_1.0.2_aarch64.dmg (~130 MB) / 4DA_1.0.2_x64.dmg (~133 MB) - 4DA_1.0.2_amd64.AppImage (~201 MB) / .deb (~133 MB) / 4DA-1.0.2-1.x86_64.rpm (~133 MB) Also fixed two latent bugs in the generator itself (template-literal regex escapes; entry-body capture defeated by ${base} braces) — its --apply path had never worked; its ignore-filter now excludes updater .app.tar.gz bundles and SBOM artifacts (new classes since #551). ## Deploy CF Pages `4da-site` is direct-upload (no Git integration): this is live only after `pnpm run cf:deploy` from site/ — the orchestrating session runs that immediately after this merges. Part of the 2026-08-31 audit remediation (lane E). 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01LrXvdHoDGUj99Fqf1fCYJY --------- Co-authored-by: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
The v0.0.15-test rehearsal published a
latest.jsoncarrying only Linux and Windows — and the workflow called it a success. Two defects, one class:bundle.targetsomittedapp, and in Tauri v2 the macOS updater archive (.app.tar.gz+.sig) derives from the app target — so macOS produced installers but no updater artifacts, and the manifest merge had nothing darwin to merge.appis macOS-only (ignored by the other bundlers); adding it restores the archives.latest.jsonexists, not that it is complete. A new fail-closed step parses the manifest and requires a signed entry for every released platform — a platform silently absent means those users never see another update, and that now blocks the release instead of passing it.Negative-tested: the new check rejects the rehearsal's actual manifest (missing
darwin-aarch64,darwin-x86_64) with exit 1. actionlint + the repo's shell-syntax gate both pass on the modified workflow.Found by the pre-tag adversarial audit's dry-run rehearsal — exactly the class it exists to catch. A second rehearsal (v0.0.16-test) validates the fix before the real tag.
🤖 Generated with Claude Code
https://claude.ai/code/session_01ENWj6RJtqDmcREYzMXXz5t