-
Notifications
You must be signed in to change notification settings - Fork 0
User Membership Integration + Volunteer #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dokicaaa
wants to merge
8
commits into
main
Choose a base branch
from
feat/user-membership
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8fcbb35
Added Membership Support
dokicaaa 252f867
Removed dev logs
dokicaaa 2a99112
fix: resolve yearly metadata bug and webhook crash in membership flow
dokicaaa 02b1688
updated env.example
dokicaaa 4865a31
fix: volunteer request sends dual email to base and applicant
dokicaaa 75ddfe0
fixed issues left from copilot reviews
dokicaaa 80682e6
Merge branch 'main' into feat/user-membership
dokicaaa e2fc73c
feat: event request room field, memberhsip fix, email error handling
dokicaaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,65 +4,4 @@ | |
|
|
||
| import { factories } from '@strapi/strapi' | ||
|
|
||
| export default factories.createCoreController('api::event-request.event-request', ({ strapi }) => ({ | ||
| async approve(ctx) { | ||
| const user = ctx.state?.user; | ||
| if (!user) { | ||
| return ctx.unauthorized(); | ||
| } | ||
|
|
||
| const { id } = ctx.params; | ||
|
|
||
| const request = (await strapi.documents('api::event-request.event-request').findOne({ | ||
| documentId: id, | ||
| populate: { event: true } as never, | ||
| })) as { | ||
| documentId: string; | ||
| status?: string; | ||
| initiatorEmail?: string; | ||
| eventName?: string; | ||
| event?: { documentId: string } | null; | ||
| } | null; | ||
|
|
||
| if (!request) { | ||
| return ctx.notFound('Event request not found'); | ||
| } | ||
|
|
||
| if (!request.event) { | ||
| return ctx.badRequest('No linked draft event found'); | ||
| } | ||
|
|
||
| if (request.status === 'approved') { | ||
| return ctx.badRequest('Event request already approved'); | ||
| } | ||
|
|
||
| try { | ||
| await strapi.documents('api::event.event').publish({ | ||
| documentId: request.event.documentId, | ||
| }); | ||
|
|
||
| await strapi.documents('api::event-request.event-request').update({ | ||
| documentId: id, | ||
| data: { status: 'approved' } as Record<string, unknown>, | ||
| }); | ||
|
|
||
| await strapi.plugins['email'].services.email.send({ | ||
| to: request.initiatorEmail, | ||
| from: '[email protected]', | ||
| replyTo: '[email protected]', | ||
| subject: 'Your event has been approved! - 42.mk', | ||
| html: ` | ||
| <p>Great news! Your event request "<strong>${request.eventName}</strong>" has been approved and is now published.</p> | ||
| <p>You can view it on our platform.</p> | ||
| <p>Best regards,<br/>42.mk Team</p> | ||
| `, | ||
| }); | ||
|
|
||
| ctx.body = { message: 'Event request approved' }; | ||
| } catch (error) { | ||
| strapi.log.error('Error approving event request:', error); | ||
| ctx.status = 500; | ||
| ctx.body = { error: { message: 'Failed to approve event request' } }; | ||
| } | ||
| }, | ||
| })); | ||
| export default factories.createCoreController('api::event-request.event-request'); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ const formToJsonMap = { | |
| "phone": "initiatorPhoneNumber", | ||
| "company-name": "organization", | ||
| "event-type": "eventType", | ||
| "room": "room", | ||
| "event-name": "eventName", | ||
| "event-theme": "eventTheme", | ||
| "event-purpose": "eventPurpose", | ||
|
|
@@ -16,13 +17,24 @@ const formToJsonMap = { | |
| "expected-guests": "expectedGuests", | ||
| }; | ||
|
|
||
| const ROOM_KEYS = ['events-hall', 'workshop-area', 'electronics-area', 'studio', 'full-space'] as const; | ||
|
|
||
| type RoomKey = (typeof ROOM_KEYS)[number]; | ||
|
|
||
| function parseRoom(value: unknown): RoomKey | undefined { | ||
| return typeof value === 'string' && (ROOM_KEYS as readonly string[]).includes(value) | ||
| ? (value as RoomKey) | ||
| : undefined; | ||
| } | ||
|
|
||
| interface EventRequestInput { | ||
| organizingEntity: string; | ||
| initiatorName: string; | ||
| initiatorEmail: string; | ||
| initiatorPhoneNumber: string; | ||
| organization: string; | ||
| eventType: string; | ||
| room?: RoomKey; | ||
| eventName: string; | ||
| eventTheme: string; | ||
| eventPurpose: string; | ||
|
|
@@ -76,13 +88,16 @@ export default { | |
| return acc; | ||
| }, {} as Record<string, unknown>); | ||
|
|
||
| const room = parseRoom(raw.room); | ||
|
|
||
| const eventRequest: EventRequestInput = { | ||
| organizingEntity: assertString(raw.organizingEntity, 'organizingEntity'), | ||
| initiatorName: assertString(raw.initiatorName, 'initiatorName'), | ||
| initiatorEmail: assertString(raw.initiatorEmail, 'initiatorEmail'), | ||
| initiatorPhoneNumber: assertString(raw.initiatorPhoneNumber, 'initiatorPhoneNumber'), | ||
| organization: assertString(raw.organization, 'organization'), | ||
| eventType: assertString(raw.eventType, 'eventType'), | ||
| ...(room !== undefined ? { room } : {}), | ||
| eventName: assertString(raw.eventName, 'eventName'), | ||
| eventTheme: assertString(raw.eventTheme, 'eventTheme'), | ||
| eventPurpose: assertString(raw.eventPurpose, 'eventPurpose'), | ||
|
|
@@ -125,6 +140,7 @@ export default { | |
| <p><strong>Initiator phone</strong> number: ${eventRequest.initiatorPhoneNumber}</p> | ||
| <p><strong>Organization:</strong> ${eventRequest.organization}</p> | ||
| <p><strong>Event type</strong>: ${eventRequest.eventType}</p> | ||
| <p><strong>Room</strong>: ${eventRequest.room}</p> | ||
| <p><strong>Event name</strong>: ${eventRequest.eventName}</p> | ||
| <p><strong>Event theme</strong>: ${eventRequest.eventTheme}</p> | ||
| <p><strong>Event purpose</strong>: ${eventRequest.eventPurpose}</p> | ||
|
|
@@ -136,55 +152,41 @@ export default { | |
| <p><strong>Expected guests</strong>: ${eventRequest.expectedGuests}</p> | ||
| `; | ||
|
|
||
| await strapi.plugins['email'].services.email.send({ | ||
| to: eventRequest.initiatorEmail, | ||
| from: '[email protected]', | ||
| replyTo: '[email protected]', | ||
| subject: 'Your event request has been received! - 42.mk', | ||
| html: `Thank you for submitting your event request. We will get back to you as soon as possible. | ||
| Here's a copy of your request: | ||
| <br/><br/> | ||
| ${requestCopy} | ||
| ` | ||
| }); | ||
|
|
||
| await strapi.plugins['email'].services.email.send({ | ||
| to: '[email protected]', | ||
| from: '[email protected]', | ||
| replyTo: eventRequest.initiatorEmail, | ||
| subject: `New event request from ${eventRequest.initiatorName}`, | ||
| html: `A new event request has been submitted. Here's a copy of the request: | ||
| <br/><br/> | ||
| ${requestCopy} | ||
| ` | ||
| }); | ||
|
|
||
| ctx.body = res; | ||
| } catch (error) { | ||
| console.error('Event request submission error:', error); | ||
|
|
||
| // Try to notify admin of the error | ||
| try { | ||
| await strapi.plugins['email'].services.email.send({ | ||
| to: eventRequest.initiatorEmail, | ||
| from: '[email protected]', | ||
| replyTo: '[email protected]', | ||
| subject: 'Your event request has been received! - 42.mk', | ||
| html: `Thank you for submitting your event request. We will get back to you as soon as possible. | ||
| Here's a copy of your request: | ||
| <br/><br/> | ||
| ${requestCopy} | ||
| ` | ||
| }); | ||
|
|
||
| await strapi.plugins['email'].services.email.send({ | ||
| to: '[email protected]', | ||
| from: '[email protected]', | ||
| subject: '[ERROR] Event request submission failed', | ||
| html: `<p>An error occurred while processing an event request submission.</p> | ||
| <p><strong>Error:</strong> ${error.message || String(error)}</p> | ||
| <p><strong>Stack:</strong></p> | ||
| <pre>${error.stack || 'No stack trace available'}</pre> | ||
| <p><strong>Request body:</strong></p> | ||
| <pre>${JSON.stringify(body, null, 2)}</pre> | ||
| replyTo: eventRequest.initiatorEmail, | ||
| subject: `New event request from ${eventRequest.initiatorName}`, | ||
| html: `A new event request has been submitted. Here's a copy of the request: | ||
| <br/><br/> | ||
| ${requestCopy} | ||
| ` | ||
| }); | ||
| } catch (emailError) { | ||
| console.error('Failed to send error notification email:', emailError); | ||
| console.error('Failed to send confirmation emails:', emailError); | ||
| } | ||
|
|
||
| ctx.body = res; | ||
| } catch (error) { | ||
| console.error('Event request submission error:', error); | ||
|
|
||
| ctx.status = 500; | ||
| ctx.body = { | ||
| error: { | ||
| message: 'Failed to submit event request. The administrator has been notified.', | ||
| message: 'Failed to submit event request.', | ||
| } | ||
| }; | ||
| } | ||
|
|
||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| import { factories } from '@strapi/strapi'; | ||
|
|
||
| export default factories.createCoreRouter('api::event-request.event-request'); | ||
| export default { | ||
| routes: [], | ||
| }; | ||
42 changes: 42 additions & 0 deletions
42
cms/src/api/membership/content-types/membership/schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "kind": "collectionType", | ||
| "collectionName": "memberships", | ||
| "info": { | ||
| "singularName": "membership", | ||
| "pluralName": "memberships", | ||
| "displayName": "Membership", | ||
| "description": "Tracks user membership subscriptions" | ||
| }, | ||
| "options": { | ||
| "draftAndPublish": false | ||
| }, | ||
| "pluginOptions": {}, | ||
| "attributes": { | ||
| "user": { | ||
| "type": "relation", | ||
| "relation": "manyToOne", | ||
| "target": "plugin::users-permissions.user", | ||
| "inversedBy": "memberships" | ||
| }, | ||
| "tier": { | ||
| "type": "enumeration", | ||
| "enum": ["monthly", "yearly"], | ||
| "required": true | ||
| }, | ||
| "status": { | ||
| "type": "enumeration", | ||
| "enum": ["active", "inactive", "cancelled", "cancel_pending", "pending"], | ||
| "default": "pending" | ||
| }, | ||
| "startDate": { | ||
| "type": "datetime" | ||
| }, | ||
| "endDate": { | ||
| "type": "datetime" | ||
| }, | ||
| "stripeSubscriptionId": { | ||
| "type": "string", | ||
| "private": true | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR removes the custom
approvecontroller method, butroutes/custom-event-request.tsstill registersPOST /event-requests/:id/approvewith handlerevent-request.approve. Strapi validates route handlers at startup, so the server throws "Handler not found" and won't boot. That route file needs to be deleted along with the controller method (the publish middleware insrc/middlewares/event-request-approval.tsalready covers the approval flow).