Repository navigation
docs: re-baseline the SDK contract to dsh 0.2.2-rc.1 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
447d0bd
docs(specs): re-baseline the wire and launch contracts to dsh-v0.2.2-…
btspoony 0a17b16
docs: pin the keyless handshake to dsh 0.2.2-rc.1 and correct two wir…
btspoony d832ff9
docs(changes): record the 0.2.2-rc.1 realignment fragment
btspoony 78a689f
docs: correct the finishReason fact and disclose the run routing dive…
btspoony c2a00d6
ci: pin the resolved dsh to the npm global bin dir (qc3 F-04)
btspoony f90f197
docs(knowledge): record additive-wire/behavioral-parity and pin-guard…
btspoony 7a5e189
docs: state the CI path guard as a location check, not a version proof
btspoony d2e0dc1
docs: state the verified runtime versions as a matrix
btspoony File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| category: Changed | ||
| --- | ||
|
|
||
| - The verified runtime baseline moved to `@deepseek-ai/[email protected]`, and both frozen contracts — the wire-parity surface and the launch contract — were re-baselined against it. The wire delta is additive: upstream now declares eight request methods while this crate still sends the same six, and `session/query`, `approval/request`, and `user-question/ask` stay deliberately unwrapped, so a leading `/` in run input is still sent to the model as prompt text rather than executed as a native command. | ||
| - Two documented facts were corrected, with no public-API change: upstream declares six server-to-client notifications while the crate still models four, `subagent.started` is emitted only for subagent-origin sessions (an ordinary fork therefore adds no tree edge), and a resumed session takes the initialized provider/model route instead of its stored selection, where a stored reasoning effort survives only when both match. The two added notification names reach the crate only through its unknown-method path. | ||
| - The runtime's install floor is documented as Node `>= 24.9.0`. The crate still installs, downloads, and versions nothing, so a caller below that bound sees the runtime's own engine failure rather than a crate error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,18 +59,19 @@ jobs: | |
| # gate is a PM decision, not a workflow change). | ||
| # | ||
| # Pin rationale: the SDK launch/wire contract was re-verified at | ||
| # deepseek-harness `dsh-v0.2.1-rc.1` (`1600d8a1`, 2026-10-16) by re-running | ||
| # the `.mstar/specs/` §10 re-verification inventories (report + review: | ||
| # `.mstar/sdd/12-dsh-0.2.1-rc1-adaptation/task-1-report.md` and | ||
| # `task-1-review.md`). The wire core holds across the range: `initialize` / | ||
| # `session/prompt` / `shutdown` and all four notifications keep their | ||
| # shapes, and the request map grew only additively — the crate wraps just | ||
| # the three both reference SDKs expose (`session/resume`, | ||
| # `session/working-directory/get|set`). `session.event.event` stays an | ||
| # untyped `Value` (wire spec §3.2), so the crate imposes no parser on the | ||
| # upstream event vocabulary and an added event kind cannot break parsing. | ||
| # Exact pin, never a dist-tag: the handshake result is reproducible run | ||
| # to run. | ||
| # deepseek-harness `dsh-v0.2.2-rc.1` (`66491b05e3`, 2026-11-04) by re-running | ||
| # the `.mstar/specs/` re-verification inventories (report + review: | ||
| # `.mstar/sdd/13-dsh-0.2.2-rc1-adaptation/task-1-report.md` and | ||
| # `task-1-review.md`). The delta is additive only: upstream now declares | ||
| # eight request methods while this crate still sends six, and six | ||
| # server-to-client notifications while this crate still models four. | ||
| # `session/query`, `approval/request`, and `user-question/ask` stay | ||
| # deliberately unwrapped (wire spec §7.7, §8), so neither the sent method | ||
| # set nor the modelled notification set changes. `session.event.event` is | ||
| # still an untyped `Value` (wire spec §3.2), so the crate imposes no parser | ||
| # on the upstream event vocabulary and an added event kind cannot break | ||
| # parsing. Exact pin, never a dist-tag: the handshake result is reproducible | ||
| # run to run. | ||
| keyless-runtime-handshake: | ||
| name: keyless runtime handshake (pinned dsh) | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -83,6 +84,9 @@ jobs: | |
| # actions/[email protected] | ||
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 | ||
| with: | ||
| # `24` resolves the newest v24.x release. The pinned runtime's | ||
| # apps/cli engines floor is `>=24.9.0`, which lives inside this same | ||
| # major, so the re-pin needed no Node major bump. | ||
| node-version: 24 | ||
|
|
||
| - name: Cache npm | ||
|
|
@@ -92,22 +96,36 @@ jobs: | |
| path: ~/.npm | ||
| # keyed on the exact pin: the tarball for that version is immutable, | ||
| # so a hit is the full npm cache the pinned global install needs | ||
| key: ${{ runner.os }}-npm-dsh-cli-0.2.1-rc.1 | ||
| key: ${{ runner.os }}-npm-dsh-cli-0.2.2-rc.1 | ||
|
|
||
| - name: Install pinned dsh runtime | ||
| # exact pin (never a dist-tag); rationale in the job comment above | ||
| run: npm install -g @deepseek-ai/[email protected].1-rc.1 | ||
| run: npm install -g @deepseek-ai/[email protected].2-rc.1 | ||
|
|
||
| - name: Resolve runtime binary | ||
| # Fail loudly when the pinned runtime cannot be resolved: an empty | ||
| # DSH_RUNTIME_BIN would make test tiers skip and the job would go | ||
| # green without ever running the handshake (qc3 F-001). | ||
| # green without ever running the handshake (qc3 F-001). The second | ||
| # guard rejects a PATH-shadowed binary: the resolved path must lie in | ||
| # the npm global bin dir, so a preinstalled `dsh` earlier on PATH fails | ||
| # loudly instead of silently running the wrong runtime (qc3 F-04). It | ||
| # is a location check, not a version check — the exact-pin guarantee | ||
| # comes from the install step above on a clean runner; it deliberately | ||
| # avoids depending on `dsh --version` output format. | ||
| run: | | ||
| NPM_GLOBAL_BIN="$(npm prefix -g)/bin" | ||
| DSH_RUNTIME_BIN="$(command -v dsh)" | ||
| if [ -z "$DSH_RUNTIME_BIN" ]; then | ||
| echo "::error::dsh not found on PATH after npm install -g @deepseek-ai/[email protected].1-rc.1" | ||
| echo "::error::dsh not found on PATH after npm install -g @deepseek-ai/[email protected].2-rc.1" | ||
| exit 1 | ||
| fi | ||
| case "$DSH_RUNTIME_BIN" in | ||
|
btspoony marked this conversation as resolved.
Resolved
|
||
| "$NPM_GLOBAL_BIN"/*) ;; | ||
| *) | ||
| echo "::error::$DSH_RUNTIME_BIN is not under the npm global bin dir $NPM_GLOBAL_BIN; refusing a PATH-shadowed dsh" | ||
| exit 1 | ||
| ;; | ||
| esac | ||
| echo "DSH_RUNTIME_BIN=$DSH_RUNTIME_BIN" >> "$GITHUB_ENV" | ||
|
|
||
| - name: Setup Rust toolchain | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.