Repository navigation
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
76f5682 to
1aa5c46
Compare
|
Closing per owner decision. The branch The watcher detach and startup ownership checks are salvaged in #12 (without the draft-root group check, so existing The deployment-profile / host-admin detector part was not merged. A live run against real sudo 1.9.13p3 and opendoas 6.8.2 in a throwaway container found:
Picking this up again would mean deciding the standard-mode threshold first (e.g. "any sudo/doas rule needs acknowledgment"), then switching to a root-side listing. |
Summary
standardandstrictdeployment profiles to the production installerstandardthe adoption-friendly default for existing non-root agent accounts--acknowledge-agent-host-admin-riskonly when direct effective probes find listed root/ALL NOPASSWD sudo policy (including command-specific entries), passwordless root doas, or writable root-owned admin control surfaces and their direct childrenstrictas the exact dedicated-agent group boundaryisolatedas an optional reference architecture requiring an operator-supplied cross-domain transport0600service-owned pending copies so retained hard links cannot mutate claimed draftsPublic CLI contract
The detector tests selected effective paths rather than classifying group names as proof of privilege. A negative result is explicitly not presented as proof that no other administration path exists.
Security behavior
Standard
nightdropgroup forbiddenStrict
nightdrop-inbox+nightdrop-mailboxeffective groupsIsolated
Documentation only: the current installer ships local paths and Unix sockets, not a cross-domain transport. A same-host container controlled by an agent-administered host does not qualify.
Verification
npm test— 157/157 passednpm run build— passedbash -n scripts/install-production.sh— passednpx --yes [email protected] scripts/install-production.sh— passedgit diff --check— passedsudoinvocation and it was not retriedScope