Skip to content

refactor!: rename project to Nightdrop - #10

Merged
404Dealer merged 3 commits into
masterfrom
rename/nightdrop-full
Jul 15, 2026
Merged

404Dealer merged 3 commits into
masterfrom
rename/nightdrop-full

Conversation

@404Dealer

@404Dealer 404Dealer commented Jul 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • rename the project identity completely to Nightdrop / nightdrop
  • publish only the nightdrop, nightdrop-oauth, nightdrop-smtp-setup, nightdrop-mailbox-cleanup, and nightdrop-mailbox executables
  • rename all active environment variables to NIGHTDROP_* and all password-store keys to nightdrop/*
  • rename production service identities and paths to nightdrop, nightdrop-inbox, nightdrop-mailbox, /opt/nightdrop, /run/nightdrop, and nightdrop.service
  • fail closed on unmanaged target identity or home collisions; managed upgrades require a root-owned marker, unique system UID/GIDs, an explicit locked service identity, exact effective service groups, bounded capability membership, and a private non-symlink home
  • require a stable unique nonzero agent UID, a same-named private primary group, and no supplementary groups beyond the two Nightdrop capabilities; serialize production installs and fail closed on NSS errors
  • require immutable root-owned installer source and install-path ancestors; ownership-track and verify removal of both the transient build user and group
  • restore runtime, configuration, systemd unit and enablement, mailbox client, protected ownership/modes/ACLs, and prior-service readiness on failed deployment; retain recovery material after any incomplete restore
  • preserve and verify application rollback ACLs/xattrs, restore mailbox metadata, and recover even when service stop or transient identity creation partially succeeds before returning failure
  • run privileged Node/npm commands under clean explicit environments and pin every executable used by OAuth and manual credential wrappers
  • package the privileged onboarding wrappers behind the three corresponding npm command names instead of exposing wrapper-enforced JavaScript internals directly
  • rename source symbols, logs, help text, documentation, examples, tests, and the Hermes skill
  • document the versioned nightdrop/*-<transaction> credential keys generated by onboarding
  • add a repository-wide acceptance test that rejects old project identities in active filenames, file content, and symlink targets

Clean-break contract

This PR intentionally adds no compatibility aliases or fallbacks. The old package commands, environment variables, password-store namespace, runtime paths, users/groups, service names, and skill identity are not accepted by the new tree.

Existing production data will be preserved by a separate rollback-capable, one-time cutover procedure. That migration is not retained as an active compatibility layer.

Verification

  • npm test — 153/153 passed
  • focused identity/package suite — 4/4 passed
  • arbitrary checkout/export path identity suite — 3/3 passed
  • npm run build — passed
  • bash -n scripts/*.sh skill/scripts/*.sh — passed
  • ShellCheck over scripts/*.sh and skill/scripts/*.sh — passed with zero diagnostics
  • npm pack --dry-run --json — package is [email protected]
  • installed-tarball smoke test — all five Nightdrop commands passed
  • active source tree scan — zero old-identity filenames/content/symlink targets
  • rebuilt dist/ scan — zero old-identity matches
  • git diff --cached --check — passed
  • independent fail-closed review of exact staged digest 4bd101d3ce981b3d1f082400d4bb108839ee5adc37be75f94447c3d4e641b984 — passed with no blocking findings
  • GitHub Actions CI — Node 20 and Node 22 passed on commit aa1add240e81b19fc2372ce7cb209be31dd208e0

Replace every active project identity and production contract with the clean-break Nightdrop name, and harden the privileged installer and onboarding boundaries.

BREAKING CHANGE: old package commands, environment variables, password-store keys, paths, services, users, groups, and compatibility aliases are removed.
@cursor

cursor Bot commented Jul 15, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@404Dealer, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8d49ccfb-d4ab-44a6-8d21-98dfe54ae938

📥 Commits

Reviewing files that changed from the base of the PR and between 9bb0f83 and aa1add2.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (51)
  • CONTRIBUTING.md
  • README.md
  • config.example.yaml
  • docs/credential-handoff.md
  • docs/deployment.md
  • docs/hermes.md
  • docs/mailbox-cleanup.md
  • docs/oauth-onboarding.md
  • docs/smtp-onboarding.md
  • package.json
  • scripts/configure-provider-secrets.sh
  • scripts/install-production.sh
  • scripts/mailbox-cleanup.sh
  • scripts/oauth-setup.sh
  • scripts/smtp-setup.sh
  • skill/SKILL.md
  • skill/scripts/draft-email.sh
  • src/bot.ts
  • src/config.ts
  • src/executor.ts
  • src/index.ts
  • src/mailbox-broker/gmail-inbox.ts
  • src/mailbox-broker/gmail-unsubscribe.ts
  • src/mailbox-broker/profiles.ts
  • src/mailbox-broker/protocol.ts
  • src/mailbox-cleanup.ts
  • src/mailbox-client.ts
  • src/mailbox/cli-options.ts
  • src/mailbox/config.ts
  • src/oauth-setup.ts
  • src/oauth/cli-options.ts
  • src/oauth/config-writer.ts
  • src/oauth/persist.ts
  • src/oauth/secret-store.ts
  • src/readiness.ts
  • src/smtp-setup.ts
  • src/smtp/cli-options.ts
  • src/watcher.ts
  • tests/executor.test.ts
  • tests/gmail-provider.test.ts
  • tests/mailbox-cleanup.test.ts
  • tests/mailbox-profiles.test.ts
  • tests/mailbox-trash-safety.test.ts
  • tests/nightdrop-identity.test.ts
  • tests/oauth-setup.test.ts
  • tests/outlook-provider.test.ts
  • tests/package.test.ts
  • tests/readiness.test.ts
  • tests/security.test.ts
  • tests/smtp-provider.test.ts
  • tests/smtp-setup.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rename/nightdrop-full

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Revalidate transient NSS identity ownership before every destructive cleanup and isolate mailbox byte-drift verification from metadata drift.
@404Dealer
404Dealer marked this pull request as ready for review July 15, 2026 02:09
Copilot AI review requested due to automatic review settings July 15, 2026 02:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@404Dealer
404Dealer merged commit eea4261 into master Jul 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants