Repository navigation
fix: a dead rollout no longer fails its task; serialize worktree setup - #24
Merged
Merged
Conversation
CI caught an intermittent failure on macOS: one rollout of a k=2 task died, and the evidence step then read that rollout's missing meta.json, so a single dead rollout failed the whole mode and hid the original error. The tasks suite now reads a rollout that never wrote meta.json as one with no deliverable, no cost and no files. The rollout most likely died because rollouts run in threads and one thread's `git worktree prune` can delete a worktree another thread is still creating. Worktree prune/add/remove now run under a lock (the agent runs themselves stay parallel). With the lock removed, 16-way concurrent workspace creation failed once in 160 attempts; with it, never. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on #23 failed intermittently on macOS / Python 3.12 in the end-to-end test:
There are two layers:
missing, as designed. The evidence step then read that rollout'smeta.jsonthrough the tasks suite, which raised. One dead rollout failed the whole mode and hid the real error. The suite now treats a rollout withoutmeta.jsonas one with no deliverable, no files and no cost.git worktree prunecan delete a worktree another thread is still creating; this race came in with the prune added in feat: Claude and ChatGPT subscriptions through the installed CLIs #14. Worktree prune/add/remove now run under a lock, and the agent runs themselves stay parallel.Test plan
ruff🤖 Generated with Claude Code