Repository navigation
Conversation
Picks up the released cut containing the dht identity fix (#1408, merged as ef6b9f69bf) and the genesis-action height guard, and drops the dependency on the pre-merge PR-branch commit e1bde75e25d0. go build ./... passes except two contract CLI packages under cross2eth/contracts/gnosis, which fail the same way on master without this bump. Co-authored-by: Claude <[email protected]>
Collaborator
Author
|
Closing: v1.76.3 already pins a chain33 commit whose tree is identical to v1.72.7 apart from CHANGELOG.md and version.go, so this bump has no functional effect. Not worth a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the chain33 dependency from the pre-merge PR-branch commit to the released v1.72.7.
The previous pin,
v1.72.7-0.20261016082959-e1bde75e25d0, points at a commit on thefix/dht-keep-established-identitybranch rather than at a released artifact. That fix is now merged asef6b9f69bf(#1408) and shipped in v1.72.7, which also carries the genesis-action height guard.Verification
go build ./...passes except two contract CLI packages,plugin/dapp/cross2eth/contracts/gnosis/bsctestandplugin/dapp/cross2eth/contracts/gnosis/chain33test(function main is undeclared in the main package). Both fail identically on master with the previous go.mod — checked by stashing this change and rebuilding — so they are pre-existing.go mod tidyproduced no further changes beyond the version line and its go.sum entries.Deployment note
chain33 v1.72.7 registers a new system fork,
ForkGenesisOnlyAtHeightZero(default0). Every config that declares[fork.system]has to declare it, orinitForkConfigpanics at startup. The configs in this repository already do; deployment repositories need the same entry.