Repository navigation
Run the canary's paid job weekly; free jobs stay daily - #3
Merged
Merged
Conversation
Paid canary paths (proxy, Scraping Browser, captcha) run weekly on Mondays; free paths keep their daily schedule. A manual dispatch runs everything. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01CKsd7q25N19WzUZjrAdzx8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: the canary runs daily, and its
canary-livejob uses theSHEIN_CDP_ENDPOINTScraping Browser endpoint (andTWOCAPTCHA_KEY; it fails with an::error::without the endpoint), so it billed on every scheduled run. Thecanary-datacentrejob need no secret and cost nothing.Change: a second schedule,
41 6 * * 1(Mondays, at the daily run's hour and minute), is added. The paid job getsif: github.event_name != 'schedule' || github.event.schedule == '41 6 * * 1', so it runs on the weekly schedule and on any manual dispatch, and is skipped on the daily one. The free jobs are not gated and keep running daily. The workflow comments now say canary-live runs weekly.Suite assertion rewritten:
smoke_test.pyasserted"event_name" not in live("canary-live must run on the schedule too"), which the gate necessarily breaks. It now asserts the weekly cron exists and that canary-live's gate names it, and still that the job is never dispatch-only. Control: deleting the gate line turns the suite red on that check (107/108, "canary-live must run on the weekly schedule"); restored, 108/108 in a core-only venv.Not changed: what each canary job runs and asserts, its thresholds, and its behaviour when a secret is missing (a paid job without its secret still fails with an
::error::naming it, now on its weekly run).workflow_dispatchstill runs every job.Evidence: the edited workflow parses as YAML and its
on.schedule/ jobif:values were printed from the parsed file (listed above). The offline suite runs in this PR'stestsworkflow on the head commit. No paid call was made to check this change.🤖 Generated with Claude Code
https://claude.ai/code/session_01CKsd7q25N19WzUZjrAdzx8