Repository navigation
v0.4.3: pyppeteer proxy auth via Fetch, refuse credentialed SOCKS - #9
Merged
Merged
Conversation
pyppeteer's page.authenticate() uses Network.setRequestInterception, which current Chrome no longer has, so any proxy with credentials crashed the run. Answer the proxy's auth challenge through the CDP Fetch domain instead. A socks5:// proxy with credentials is now bad usage (exit 2) rather than a Playwright traceback, since Chromium cannot authenticate to SOCKS. Also ignore the per-engine .venv-*/ environments. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems found in the live proxy test
page.authenticate()callsNetwork.setRequestInterception, which current Chrome no longer has:Protocol error (Network.setRequestInterception): 'Network.setRequestInterception' wasn't found.socks5://user:pass@…crashed Playwright with a traceback:Browser does not support socks5 proxy authentication.Fix
Fetchdomain (Fetch.enablewithhandleAuthRequests, thenFetch.continueWithAuth). Credentials go only to a challenge whosesourceisProxy.proxy_pool.parse_proxy_linerefuses a credentialed SOCKS proxy as bad usage (exit 2). The message does not echo the password. A SOCKS proxy without credentials is still accepted..gitignoregets.venv-*/.Verified live
The test ran through a local HTTP proxy that requires a login and password (it rejects missing or wrong credentials) and forwards to a 2captcha US residential proxy.
--proxy-servercannot authenticate.smoke_test.py: 79/79.🤖 Generated with Claude Code