Repository navigation
v0.4.2: --fingerprint actually applies the profile's user agent - #8
Merged
Merged
Conversation
The live Fingerprint API returns the UA at userAgent.userAgent (and navigator.userAgent), not userAgent.value, so --fingerprint silently kept the browser's own UA on every engine. Read the real shape, warn when a profile has none, and add a smoke check on the live-confirmed structure. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
--fingerprintnever changed the user agent. The live 2Captcha Fingerprint API returns it atuserAgent.userAgent(and again atnavigator.userAgent), butuser_agent_from()readuserAgent.value. It gotNone, and every engine silently kept the browser's own UA.Fix
user_agent_from()readsuserAgent.userAgent, then falls back tonavigator.userAgentand to a plain string.Verified
smoke_test.py: 78/78.--fingerprint(no proxy, no CDP):navigator.userAgentin the browser equals the profile's UA (Android Chrome 152), 10 rows of "whole milk".🤖 Generated with Claude Code