Repository navigation
v0.4.1: pyppeteer CDP connect timeout; Scraping Browser path verified live - #7
Merged
Merged
Conversation
…live The Scraping Browser API answers 500 "profile_locked" while another session still holds the profile, and pyppeteer's connect() then never returns: a pyppeteer run started right after a Playwright run hung for ten minutes. connect() now times out after 30 s into the usual "CDP connection failed" exit 5. Every --cdp-endpoint run also warned "Ignoring --fingerprint" without --fingerprint; it now warns only when the flag was passed. Playwright and pyppeteer over a live US Scraping Browser session: store pricing, 60-row pagination and a deals page match local runs. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first live run of the Scraping Browser path (
--cdp-endpoint) found two problems:profile_lockedwhile another session still holds the profile, including for a few seconds after the previous run ends. pyppeteer'sconnect()never returns in that case. A pyppeteer run started right after a Playwright run hung for ten minutes. Reproduced by holding the profile from one process and connecting from another.connect()now times out after 30 s and reports the usual "CDP connection failed" (exit 5), which is how Playwright already handled it.--cdp-endpointrun warned "Ignoring --fingerprint" even when--fingerprintwas not passed. It now warns only when the flag is given.Live results over a US Scraping Browser session:
--store-id 1449at the store ($4.25).milk ×60completed.smoke_test.py: 77/77 under all three engine environments. A new check covers the connect timeout.🤖 Generated with Claude Code