Repository navigation
v0.4.4: never echo a malformed proxy line; stop pyppeteer proxy auth before close - #10
Merged
Merged
Conversation
…before close Ported from tipranks-scraper's live test pass. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes ported from the tipranks-scraper live test pass (2scraper/tipranks-scraper#6).
proxy_pool.parse_proxy_line: a malformed line was echoed inProxyParseError(unrecognised proxy format: 'http://user:pass@…'), which can expose its password. The message now lists the accepted formats instead.Fetch.disablebefore bothbrowser.close()paths when proxy auth is on. In tipranks a paused request answered while the target closed left an unretrieved "Target closed" error on stderr. Here it was not seen, but the timing is the same.Verified
smoke_test.py: 81/81 in every engine venv and with no engine installed (two new checks).--proxyexits 2 and the password is not in the message.🤖 Generated with Claude Code